]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Catch situations where currentframe() returns None. See SF patch #1447410, this is...
authorVinay Sajip <vinay_sajip@yahoo.co.uk>
Mon, 20 Mar 2006 09:22:40 +0000 (09:22 +0000)
committerVinay Sajip <vinay_sajip@yahoo.co.uk>
Mon, 20 Mar 2006 09:22:40 +0000 (09:22 +0000)
Lib/logging/__init__.py

index 5a0b0f50213dce22df1c43f73fd4b4b73e81d63f..a7210e1a9c4ff9ba65ac05eb3e6c98040803d82b 100644 (file)
@@ -1045,13 +1045,16 @@ class Logger(Filterer):
         file name, line number and function name.
         """
         f = currentframe().f_back
-        while 1:
+        rv = "(unknown file)", 0, "(unknown function)"
+        while hasattr(f, "f_code"):
             co = f.f_code
             filename = os.path.normcase(co.co_filename)
             if filename == _srcfile:
                 f = f.f_back
                 continue
-            return filename, f.f_lineno, co.co_name
+            rv = (filename, f.f_lineno, co.co_name)
+            break
+        return rv
 
     def makeRecord(self, name, level, fn, lno, msg, args, exc_info):
         """
@@ -1324,12 +1327,14 @@ def shutdown():
     """
     for h in _handlerList[:]: # was _handlers.keys():
         #errors might occur, for example, if files are locked
-        #we just ignore them
+        #we just ignore them if raiseExceptions is not set
         try:
             h.flush()
             h.close()
         except:
-            pass
+            if raiseExceptions:
+                raise
+            #else, swallow
 
 #Let's try and shutdown automatically on application exit...
 try: