]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.10-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Jul 2024 09:54:28 +0000 (11:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Jul 2024 09:54:28 +0000 (11:54 +0200)
added patches:
perf-x86-intel-pt-fix-a-topa_entry-base-address-calculation.patch
perf-x86-intel-pt-fix-topa_entry-base-length.patch
platform-mips-cpu_hwmon-disable-driver-on-unsupported-hardware.patch
rtc-isl1208-fix-return-value-of-nvmem-callbacks.patch
scsi-qla2xxx-complete-command-early-within-lock.patch
scsi-qla2xxx-during-vport-delete-send-async-logout-explicitly.patch
scsi-qla2xxx-fix-flash-read-failure.patch
scsi-qla2xxx-fix-for-possible-memory-corruption.patch
scsi-qla2xxx-validate-nvme_local_port-correctly.patch
watchdog-perf-properly-initialize-the-turbo-mode-timestamp-and-rearm-counter.patch

queue-5.10/perf-x86-intel-pt-fix-a-topa_entry-base-address-calculation.patch [new file with mode: 0644]
queue-5.10/perf-x86-intel-pt-fix-topa_entry-base-length.patch [new file with mode: 0644]
queue-5.10/platform-mips-cpu_hwmon-disable-driver-on-unsupported-hardware.patch [new file with mode: 0644]
queue-5.10/rtc-isl1208-fix-return-value-of-nvmem-callbacks.patch [new file with mode: 0644]
queue-5.10/scsi-qla2xxx-complete-command-early-within-lock.patch [new file with mode: 0644]
queue-5.10/scsi-qla2xxx-during-vport-delete-send-async-logout-explicitly.patch [new file with mode: 0644]
queue-5.10/scsi-qla2xxx-fix-flash-read-failure.patch [new file with mode: 0644]
queue-5.10/scsi-qla2xxx-fix-for-possible-memory-corruption.patch [new file with mode: 0644]
queue-5.10/scsi-qla2xxx-validate-nvme_local_port-correctly.patch [new file with mode: 0644]
queue-5.10/series
queue-5.10/watchdog-perf-properly-initialize-the-turbo-mode-timestamp-and-rearm-counter.patch [new file with mode: 0644]

diff --git a/queue-5.10/perf-x86-intel-pt-fix-a-topa_entry-base-address-calculation.patch b/queue-5.10/perf-x86-intel-pt-fix-a-topa_entry-base-address-calculation.patch
new file mode 100644 (file)
index 0000000..a459ae5
--- /dev/null
@@ -0,0 +1,46 @@
+From ad97196379d0b8cb24ef3d5006978a6554e6467f Mon Sep 17 00:00:00 2001
+From: Adrian Hunter <adrian.hunter@intel.com>
+Date: Mon, 24 Jun 2024 23:10:56 +0300
+Subject: perf/x86/intel/pt: Fix a topa_entry base address calculation
+
+From: Adrian Hunter <adrian.hunter@intel.com>
+
+commit ad97196379d0b8cb24ef3d5006978a6554e6467f upstream.
+
+topa_entry->base is a bit-field. Bit-fields are not promoted to a 64-bit
+type, even if the underlying type is 64-bit, and so, if necessary, must
+be cast to a larger type when calculations are done.
+
+Fix a topa_entry->base address calculation by adding a cast.
+
+Without the cast, the address was limited to 36-bits i.e. 64GiB.
+
+The address calculation is used on systems that do not support Multiple
+Entry ToPA (only Broadwell), and affects physical addresses on or above
+64GiB. Instead of writing to the correct address, the address comprising
+the first 36 bits would be written to.
+
+Intel PT snapshot and sampling modes are not affected.
+
+Fixes: 52ca9ced3f70 ("perf/x86/intel/pt: Add Intel PT PMU driver")
+Reported-by: Dave Hansen <dave.hansen@linux.intel.com>
+Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
+Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
+Cc: stable@vger.kernel.org
+Link: https://lore.kernel.org/r/20240624201101.60186-3-adrian.hunter@intel.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ arch/x86/events/intel/pt.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/arch/x86/events/intel/pt.c
++++ b/arch/x86/events/intel/pt.c
+@@ -861,7 +861,7 @@ static void pt_update_head(struct pt *pt
+  */
+ static void *pt_buffer_region(struct pt_buffer *buf)
+ {
+-      return phys_to_virt(TOPA_ENTRY(buf->cur, buf->cur_idx)->base << TOPA_SHIFT);
++      return phys_to_virt((phys_addr_t)TOPA_ENTRY(buf->cur, buf->cur_idx)->base << TOPA_SHIFT);
+ }
+ /**
diff --git a/queue-5.10/perf-x86-intel-pt-fix-topa_entry-base-length.patch b/queue-5.10/perf-x86-intel-pt-fix-topa_entry-base-length.patch
new file mode 100644 (file)
index 0000000..1bb968c
--- /dev/null
@@ -0,0 +1,44 @@
+From 5638bd722a44bbe97c1a7b3fae5b9efddb3e70ff Mon Sep 17 00:00:00 2001
+From: Marco Cavenati <cavenati.marco@gmail.com>
+Date: Mon, 24 Jun 2024 23:10:55 +0300
+Subject: perf/x86/intel/pt: Fix topa_entry base length
+
+From: Marco Cavenati <cavenati.marco@gmail.com>
+
+commit 5638bd722a44bbe97c1a7b3fae5b9efddb3e70ff upstream.
+
+topa_entry->base needs to store a pfn.  It obviously needs to be
+large enough to store the largest possible x86 pfn which is
+MAXPHYADDR-PAGE_SIZE (52-12).  So it is 4 bits too small.
+
+Increase the size of topa_entry->base from 36 bits to 40 bits.
+
+Note, systems where physical addresses can be 256TiB or more are affected.
+
+[ Adrian: Amend commit message as suggested by Dave Hansen ]
+
+Fixes: 52ca9ced3f70 ("perf/x86/intel/pt: Add Intel PT PMU driver")
+Signed-off-by: Marco Cavenati <cavenati.marco@gmail.com>
+Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
+Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
+Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
+Cc: stable@vger.kernel.org
+Link: https://lore.kernel.org/r/20240624201101.60186-2-adrian.hunter@intel.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ arch/x86/events/intel/pt.h |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/arch/x86/events/intel/pt.h
++++ b/arch/x86/events/intel/pt.h
+@@ -33,8 +33,8 @@ struct topa_entry {
+       u64     rsvd2   : 1;
+       u64     size    : 4;
+       u64     rsvd3   : 2;
+-      u64     base    : 36;
+-      u64     rsvd4   : 16;
++      u64     base    : 40;
++      u64     rsvd4   : 12;
+ };
+ /* TSC to Core Crystal Clock Ratio */
diff --git a/queue-5.10/platform-mips-cpu_hwmon-disable-driver-on-unsupported-hardware.patch b/queue-5.10/platform-mips-cpu_hwmon-disable-driver-on-unsupported-hardware.patch
new file mode 100644 (file)
index 0000000..1b2e55a
--- /dev/null
@@ -0,0 +1,32 @@
+From f4d430db17b4ef4e9c3c352a04b2fe3c93011978 Mon Sep 17 00:00:00 2001
+From: Jiaxun Yang <jiaxun.yang@flygoat.com>
+Date: Fri, 14 Jun 2024 16:40:15 +0100
+Subject: platform: mips: cpu_hwmon: Disable driver on unsupported hardware
+
+From: Jiaxun Yang <jiaxun.yang@flygoat.com>
+
+commit f4d430db17b4ef4e9c3c352a04b2fe3c93011978 upstream.
+
+cpu_hwmon is unsupported on CPUs without loongson_chiptemp
+register and csr.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
+Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/platform/mips/cpu_hwmon.c |    3 +++
+ 1 file changed, 3 insertions(+)
+
+--- a/drivers/platform/mips/cpu_hwmon.c
++++ b/drivers/platform/mips/cpu_hwmon.c
+@@ -139,6 +139,9 @@ static int __init loongson_hwmon_init(vo
+               csr_temp_enable = csr_readl(LOONGSON_CSR_FEATURES) &
+                                 LOONGSON_CSRF_TEMP;
++      if (!csr_temp_enable && !loongson_chiptemp[0])
++              return -ENODEV;
++
+       nr_packages = loongson_sysconf.nr_cpus /
+               loongson_sysconf.cores_per_package;
diff --git a/queue-5.10/rtc-isl1208-fix-return-value-of-nvmem-callbacks.patch b/queue-5.10/rtc-isl1208-fix-return-value-of-nvmem-callbacks.patch
new file mode 100644 (file)
index 0000000..c99c2f6
--- /dev/null
@@ -0,0 +1,63 @@
+From 70f1ae5f0e7f44edf842444044615da7b59838c1 Mon Sep 17 00:00:00 2001
+From: Joy Chakraborty <joychakr@google.com>
+Date: Wed, 12 Jun 2024 08:08:31 +0000
+Subject: rtc: isl1208: Fix return value of nvmem callbacks
+
+From: Joy Chakraborty <joychakr@google.com>
+
+commit 70f1ae5f0e7f44edf842444044615da7b59838c1 upstream.
+
+Read/write callbacks registered with nvmem core expect 0 to be returned
+on success and a negative value to be returned on failure.
+
+isl1208_nvmem_read()/isl1208_nvmem_write() currently return the number of
+bytes read/written on success, fix to return 0 on success and negative on
+failure.
+
+Fixes: c3544f6f51ed ("rtc: isl1208: Add new style nvmem support to driver")
+Cc: stable@vger.kernel.org
+Signed-off-by: Joy Chakraborty <joychakr@google.com>
+Link: https://lore.kernel.org/r/20240612080831.1227131-1-joychakr@google.com
+Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/rtc/rtc-isl1208.c |   11 ++++-------
+ 1 file changed, 4 insertions(+), 7 deletions(-)
+
+--- a/drivers/rtc/rtc-isl1208.c
++++ b/drivers/rtc/rtc-isl1208.c
+@@ -743,14 +743,13 @@ static int isl1208_nvmem_read(void *priv
+ {
+       struct isl1208_state *isl1208 = priv;
+       struct i2c_client *client = to_i2c_client(isl1208->rtc->dev.parent);
+-      int ret;
+       /* nvmem sanitizes offset/count for us, but count==0 is possible */
+       if (!count)
+               return count;
+-      ret = isl1208_i2c_read_regs(client, ISL1208_REG_USR1 + off, buf,
++
++      return isl1208_i2c_read_regs(client, ISL1208_REG_USR1 + off, buf,
+                                   count);
+-      return ret == 0 ? count : ret;
+ }
+ static int isl1208_nvmem_write(void *priv, unsigned int off, void *buf,
+@@ -758,15 +757,13 @@ static int isl1208_nvmem_write(void *pri
+ {
+       struct isl1208_state *isl1208 = priv;
+       struct i2c_client *client = to_i2c_client(isl1208->rtc->dev.parent);
+-      int ret;
+       /* nvmem sanitizes off/count for us, but count==0 is possible */
+       if (!count)
+               return count;
+-      ret = isl1208_i2c_set_regs(client, ISL1208_REG_USR1 + off, buf,
+-                                 count);
+-      return ret == 0 ? count : ret;
++      return isl1208_i2c_set_regs(client, ISL1208_REG_USR1 + off, buf,
++                                 count);
+ }
+ static const struct nvmem_config isl1208_nvmem_config = {
diff --git a/queue-5.10/scsi-qla2xxx-complete-command-early-within-lock.patch b/queue-5.10/scsi-qla2xxx-complete-command-early-within-lock.patch
new file mode 100644 (file)
index 0000000..830c2f9
--- /dev/null
@@ -0,0 +1,79 @@
+From 4475afa2646d3fec176fc4d011d3879b26cb26e3 Mon Sep 17 00:00:00 2001
+From: Shreyas Deodhar <sdeodhar@marvell.com>
+Date: Wed, 10 Jul 2024 22:40:52 +0530
+Subject: scsi: qla2xxx: Complete command early within lock
+
+From: Shreyas Deodhar <sdeodhar@marvell.com>
+
+commit 4475afa2646d3fec176fc4d011d3879b26cb26e3 upstream.
+
+A crash was observed while performing NPIV and FW reset,
+
+ BUG: kernel NULL pointer dereference, address: 000000000000001c
+ #PF: supervisor read access in kernel mode
+ #PF: error_code(0x0000) - not-present page
+ PGD 0 P4D 0
+ Oops: 0000 1 PREEMPT_RT SMP NOPTI
+ RIP: 0010:dma_direct_unmap_sg+0x51/0x1e0
+ RSP: 0018:ffffc90026f47b88 EFLAGS: 00010246
+ RAX: 0000000000000000 RBX: 0000000000000021 RCX: 0000000000000002
+ RDX: 0000000000000021 RSI: 0000000000000000 RDI: ffff8881041130d0
+ RBP: ffff8881041130d0 R08: 0000000000000000 R09: 0000000000000034
+ R10: ffffc90026f47c48 R11: 0000000000000031 R12: 0000000000000000
+ R13: 0000000000000000 R14: ffff8881565e4a20 R15: 0000000000000000
+ FS: 00007f4c69ed3d00(0000) GS:ffff889faac80000(0000) knlGS:0000000000000000
+ CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
+ CR2: 000000000000001c CR3: 0000000288a50002 CR4: 00000000007706e0
+ DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
+ DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
+ PKRU: 55555554
+ Call Trace:
+ <TASK>
+ ? __die_body+0x1a/0x60
+ ? page_fault_oops+0x16f/0x4a0
+ ? do_user_addr_fault+0x174/0x7f0
+ ? exc_page_fault+0x69/0x1a0
+ ? asm_exc_page_fault+0x22/0x30
+ ? dma_direct_unmap_sg+0x51/0x1e0
+ ? preempt_count_sub+0x96/0xe0
+ qla2xxx_qpair_sp_free_dma+0x29f/0x3b0 [qla2xxx]
+ qla2xxx_qpair_sp_compl+0x60/0x80 [qla2xxx]
+ __qla2x00_abort_all_cmds+0xa2/0x450 [qla2xxx]
+
+The command completion was done early while aborting the commands in driver
+unload path but outside lock to avoid the WARN_ON condition of performing
+dma_free_attr within the lock. However this caused race condition while
+command completion via multiple paths causing system crash.
+
+Hence complete the command early in unload path but within the lock to
+avoid race condition.
+
+Fixes: 0367076b0817 ("scsi: qla2xxx: Perform lockless command completion in abort path")
+Cc: stable@vger.kernel.org
+Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
+Signed-off-by: Nilesh Javali <njavali@marvell.com>
+Link: https://lore.kernel.org/r/20240710171057.35066-7-njavali@marvell.com
+Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
+Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/scsi/qla2xxx/qla_os.c |    5 -----
+ 1 file changed, 5 deletions(-)
+
+--- a/drivers/scsi/qla2xxx/qla_os.c
++++ b/drivers/scsi/qla2xxx/qla_os.c
+@@ -1752,14 +1752,9 @@ __qla2x00_abort_all_cmds(struct qla_qpai
+       for (cnt = 1; cnt < req->num_outstanding_cmds; cnt++) {
+               sp = req->outstanding_cmds[cnt];
+               if (sp) {
+-                      /*
+-                       * perform lockless completion during driver unload
+-                       */
+                       if (qla2x00_chip_is_down(vha)) {
+                               req->outstanding_cmds[cnt] = NULL;
+-                              spin_unlock_irqrestore(qp->qp_lock_ptr, flags);
+                               sp->done(sp, res);
+-                              spin_lock_irqsave(qp->qp_lock_ptr, flags);
+                               continue;
+                       }
diff --git a/queue-5.10/scsi-qla2xxx-during-vport-delete-send-async-logout-explicitly.patch b/queue-5.10/scsi-qla2xxx-during-vport-delete-send-async-logout-explicitly.patch
new file mode 100644 (file)
index 0000000..be2b729
--- /dev/null
@@ -0,0 +1,73 @@
+From 76f480d7c717368f29a3870f7d64471ce0ff8fb2 Mon Sep 17 00:00:00 2001
+From: Manish Rangankar <mrangankar@marvell.com>
+Date: Wed, 10 Jul 2024 22:40:53 +0530
+Subject: scsi: qla2xxx: During vport delete send async logout explicitly
+
+From: Manish Rangankar <mrangankar@marvell.com>
+
+commit 76f480d7c717368f29a3870f7d64471ce0ff8fb2 upstream.
+
+During vport delete, it is observed that during unload we hit a crash
+because of stale entries in outstanding command array.  For all these stale
+I/O entries, eh_abort was issued and aborted (fast_fail_io = 2009h) but
+I/Os could not complete while vport delete is in process of deleting.
+
+  BUG: kernel NULL pointer dereference, address: 000000000000001c
+  #PF: supervisor read access in kernel mode
+  #PF: error_code(0x0000) - not-present page
+  PGD 0 P4D 0
+  Oops: 0000 [#1] PREEMPT SMP NOPTI
+  Workqueue: qla2xxx_wq qla_do_work [qla2xxx]
+  RIP: 0010:dma_direct_unmap_sg+0x51/0x1e0
+  RSP: 0018:ffffa1e1e150fc68 EFLAGS: 00010046
+  RAX: 0000000000000000 RBX: 0000000000000021 RCX: 0000000000000001
+  RDX: 0000000000000021 RSI: 0000000000000000 RDI: ffff8ce208a7a0d0
+  RBP: ffff8ce208a7a0d0 R08: 0000000000000000 R09: ffff8ce378aac9c8
+  R10: ffff8ce378aac8a0 R11: ffffa1e1e150f9d8 R12: 0000000000000000
+  R13: 0000000000000000 R14: ffff8ce378aac9c8 R15: 0000000000000000
+  FS:  0000000000000000(0000) GS:ffff8d217f000000(0000) knlGS:0000000000000000
+  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
+  CR2: 000000000000001c CR3: 0000002089acc000 CR4: 0000000000350ee0
+  Call Trace:
+  <TASK>
+  qla2xxx_qpair_sp_free_dma+0x417/0x4e0
+  ? qla2xxx_qpair_sp_compl+0x10d/0x1a0
+  ? qla2x00_status_entry+0x768/0x2830
+  ? newidle_balance+0x2f0/0x430
+  ? dequeue_entity+0x100/0x3c0
+  ? qla24xx_process_response_queue+0x6a1/0x19e0
+  ? __schedule+0x2d5/0x1140
+  ? qla_do_work+0x47/0x60
+  ? process_one_work+0x267/0x440
+  ? process_one_work+0x440/0x440
+  ? worker_thread+0x2d/0x3d0
+  ? process_one_work+0x440/0x440
+  ? kthread+0x156/0x180
+  ? set_kthread_struct+0x50/0x50
+  ? ret_from_fork+0x22/0x30
+  </TASK>
+
+Send out async logout explicitly for all the ports during vport delete.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Manish Rangankar <mrangankar@marvell.com>
+Signed-off-by: Nilesh Javali <njavali@marvell.com>
+Link: https://lore.kernel.org/r/20240710171057.35066-8-njavali@marvell.com
+Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
+Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/scsi/qla2xxx/qla_mid.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/scsi/qla2xxx/qla_mid.c
++++ b/drivers/scsi/qla2xxx/qla_mid.c
+@@ -164,7 +164,7 @@ qla24xx_disable_vp(scsi_qla_host_t *vha)
+       atomic_set(&vha->loop_state, LOOP_DOWN);
+       atomic_set(&vha->loop_down_timer, LOOP_DOWN_TIME);
+       list_for_each_entry(fcport, &vha->vp_fcports, list)
+-              fcport->logout_on_delete = 0;
++              fcport->logout_on_delete = 1;
+       qla2x00_mark_all_devices_lost(vha);
diff --git a/queue-5.10/scsi-qla2xxx-fix-flash-read-failure.patch b/queue-5.10/scsi-qla2xxx-fix-flash-read-failure.patch
new file mode 100644 (file)
index 0000000..8d91338
--- /dev/null
@@ -0,0 +1,371 @@
+From 29e222085d8907ccff18ecd931bdd4c6b1f11b92 Mon Sep 17 00:00:00 2001
+From: Quinn Tran <qutran@marvell.com>
+Date: Wed, 10 Jul 2024 22:40:51 +0530
+Subject: scsi: qla2xxx: Fix flash read failure
+
+From: Quinn Tran <qutran@marvell.com>
+
+commit 29e222085d8907ccff18ecd931bdd4c6b1f11b92 upstream.
+
+Link up failure is observed as a result of flash read failure.  Current
+code does not check flash read return code where it relies on FW checksum
+to detect the problem.
+
+Add check of flash read failure to detect the problem sooner.
+
+Reported-by: kernel test robot <lkp@intel.com>
+Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
+Closes: https://lore.kernel.org/all/202406210815.rPDRDMBi-lkp@intel.com/
+Cc: stable@vger.kernel.org
+Signed-off-by: Quinn Tran <qutran@marvell.com>
+Signed-off-by: Nilesh Javali <njavali@marvell.com>
+Link: https://lore.kernel.org/r/20240710171057.35066-6-njavali@marvell.com
+Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
+Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/scsi/qla2xxx/qla_init.c |   63 ++++++++++++++++++-----
+ drivers/scsi/qla2xxx/qla_sup.c  |  108 +++++++++++++++++++++++++++-------------
+ 2 files changed, 125 insertions(+), 46 deletions(-)
+
+--- a/drivers/scsi/qla2xxx/qla_init.c
++++ b/drivers/scsi/qla2xxx/qla_init.c
+@@ -7696,15 +7696,21 @@ qla28xx_get_aux_images(
+       struct qla27xx_image_status pri_aux_image_status, sec_aux_image_status;
+       bool valid_pri_image = false, valid_sec_image = false;
+       bool active_pri_image = false, active_sec_image = false;
++      int rc;
+       if (!ha->flt_region_aux_img_status_pri) {
+               ql_dbg(ql_dbg_init, vha, 0x018a, "Primary aux image not addressed\n");
+               goto check_sec_image;
+       }
+-      qla24xx_read_flash_data(vha, (uint32_t *)&pri_aux_image_status,
++      rc = qla24xx_read_flash_data(vha, (uint32_t *)&pri_aux_image_status,
+           ha->flt_region_aux_img_status_pri,
+           sizeof(pri_aux_image_status) >> 2);
++      if (rc) {
++              ql_log(ql_log_info, vha, 0x01a1,
++                  "Unable to read Primary aux image(%x).\n", rc);
++              goto check_sec_image;
++      }
+       qla27xx_print_image(vha, "Primary aux image", &pri_aux_image_status);
+       if (qla28xx_check_aux_image_status_signature(&pri_aux_image_status)) {
+@@ -7735,9 +7741,15 @@ check_sec_image:
+               goto check_valid_image;
+       }
+-      qla24xx_read_flash_data(vha, (uint32_t *)&sec_aux_image_status,
++      rc = qla24xx_read_flash_data(vha, (uint32_t *)&sec_aux_image_status,
+           ha->flt_region_aux_img_status_sec,
+           sizeof(sec_aux_image_status) >> 2);
++      if (rc) {
++              ql_log(ql_log_info, vha, 0x01a2,
++                  "Unable to read Secondary aux image(%x).\n", rc);
++              goto check_valid_image;
++      }
++
+       qla27xx_print_image(vha, "Secondary aux image", &sec_aux_image_status);
+       if (qla28xx_check_aux_image_status_signature(&sec_aux_image_status)) {
+@@ -7794,6 +7806,7 @@ qla27xx_get_active_image(struct scsi_qla
+       struct qla27xx_image_status pri_image_status, sec_image_status;
+       bool valid_pri_image = false, valid_sec_image = false;
+       bool active_pri_image = false, active_sec_image = false;
++      int rc;
+       if (!ha->flt_region_img_status_pri) {
+               ql_dbg(ql_dbg_init, vha, 0x018a, "Primary image not addressed\n");
+@@ -7835,8 +7848,14 @@ check_sec_image:
+               goto check_valid_image;
+       }
+-      qla24xx_read_flash_data(vha, (uint32_t *)(&sec_image_status),
++      rc = qla24xx_read_flash_data(vha, (uint32_t *)(&sec_image_status),
+           ha->flt_region_img_status_sec, sizeof(sec_image_status) >> 2);
++      if (rc) {
++              ql_log(ql_log_info, vha, 0x01a3,
++                  "Unable to read Secondary image status(%x).\n", rc);
++              goto check_valid_image;
++      }
++
+       qla27xx_print_image(vha, "Secondary image", &sec_image_status);
+       if (qla27xx_check_image_status_signature(&sec_image_status)) {
+@@ -7908,11 +7927,10 @@ qla24xx_load_risc_flash(scsi_qla_host_t
+           "FW: Loading firmware from flash (%x).\n", faddr);
+       dcode = (uint32_t *)req->ring;
+-      qla24xx_read_flash_data(vha, dcode, faddr, 8);
+-      if (qla24xx_risc_firmware_invalid(dcode)) {
++      rval = qla24xx_read_flash_data(vha, dcode, faddr, 8);
++      if (rval || qla24xx_risc_firmware_invalid(dcode)) {
+               ql_log(ql_log_fatal, vha, 0x008c,
+-                  "Unable to verify the integrity of flash firmware "
+-                  "image.\n");
++                  "Unable to verify the integrity of flash firmware image (rval %x).\n", rval);
+               ql_log(ql_log_fatal, vha, 0x008d,
+                   "Firmware data: %08x %08x %08x %08x.\n",
+                   dcode[0], dcode[1], dcode[2], dcode[3]);
+@@ -7926,7 +7944,12 @@ qla24xx_load_risc_flash(scsi_qla_host_t
+       for (j = 0; j < segments; j++) {
+               ql_dbg(ql_dbg_init, vha, 0x008d,
+                   "-> Loading segment %u...\n", j);
+-              qla24xx_read_flash_data(vha, dcode, faddr, 10);
++              rval = qla24xx_read_flash_data(vha, dcode, faddr, 10);
++              if (rval) {
++                      ql_log(ql_log_fatal, vha, 0x016a,
++                          "-> Unable to read segment addr + size .\n");
++                      return QLA_FUNCTION_FAILED;
++              }
+               risc_addr = be32_to_cpu((__force __be32)dcode[2]);
+               risc_size = be32_to_cpu((__force __be32)dcode[3]);
+               if (!*srisc_addr) {
+@@ -7942,7 +7965,13 @@ qla24xx_load_risc_flash(scsi_qla_host_t
+                       ql_dbg(ql_dbg_init, vha, 0x008e,
+                           "-> Loading fragment %u: %#x <- %#x (%#lx dwords)...\n",
+                           fragment, risc_addr, faddr, dlen);
+-                      qla24xx_read_flash_data(vha, dcode, faddr, dlen);
++                      rval = qla24xx_read_flash_data(vha, dcode, faddr, dlen);
++                      if (rval) {
++                              ql_log(ql_log_fatal, vha, 0x016b,
++                                  "-> Unable to read fragment(faddr %#x dlen %#lx).\n",
++                                  faddr, dlen);
++                              return QLA_FUNCTION_FAILED;
++                      }
+                       for (i = 0; i < dlen; i++)
+                               dcode[i] = swab32(dcode[i]);
+@@ -7972,7 +8001,14 @@ qla24xx_load_risc_flash(scsi_qla_host_t
+               fwdt->length = 0;
+               dcode = (uint32_t *)req->ring;
+-              qla24xx_read_flash_data(vha, dcode, faddr, 7);
++
++              rval = qla24xx_read_flash_data(vha, dcode, faddr, 7);
++              if (rval) {
++                      ql_log(ql_log_fatal, vha, 0x016c,
++                          "-> Unable to read template size.\n");
++                      goto failed;
++              }
++
+               risc_size = be32_to_cpu((__force __be32)dcode[2]);
+               ql_dbg(ql_dbg_init, vha, 0x0161,
+                   "-> fwdt%u template array at %#x (%#x dwords)\n",
+@@ -7998,11 +8034,12 @@ qla24xx_load_risc_flash(scsi_qla_host_t
+               }
+               dcode = fwdt->template;
+-              qla24xx_read_flash_data(vha, dcode, faddr, risc_size);
++              rval = qla24xx_read_flash_data(vha, dcode, faddr, risc_size);
+-              if (!qla27xx_fwdt_template_valid(dcode)) {
++              if (rval || !qla27xx_fwdt_template_valid(dcode)) {
+                       ql_log(ql_log_warn, vha, 0x0165,
+-                          "-> fwdt%u failed template validate\n", j);
++                          "-> fwdt%u failed template validate (rval %x)\n",
++                          j, rval);
+                       goto failed;
+               }
+--- a/drivers/scsi/qla2xxx/qla_sup.c
++++ b/drivers/scsi/qla2xxx/qla_sup.c
+@@ -555,6 +555,7 @@ qla2xxx_find_flt_start(scsi_qla_host_t *
+       struct qla_flt_location *fltl = (void *)req->ring;
+       uint32_t *dcode = (uint32_t *)req->ring;
+       uint8_t *buf = (void *)req->ring, *bcode,  last_image;
++      int rc;
+       /*
+        * FLT-location structure resides after the last PCI region.
+@@ -584,14 +585,24 @@ qla2xxx_find_flt_start(scsi_qla_host_t *
+       pcihdr = 0;
+       do {
+               /* Verify PCI expansion ROM header. */
+-              qla24xx_read_flash_data(vha, dcode, pcihdr >> 2, 0x20);
++              rc = qla24xx_read_flash_data(vha, dcode, pcihdr >> 2, 0x20);
++              if (rc) {
++                      ql_log(ql_log_info, vha, 0x016d,
++                          "Unable to read PCI Expansion Rom Header (%x).\n", rc);
++                      return QLA_FUNCTION_FAILED;
++              }
+               bcode = buf + (pcihdr % 4);
+               if (bcode[0x0] != 0x55 || bcode[0x1] != 0xaa)
+                       goto end;
+               /* Locate PCI data structure. */
+               pcids = pcihdr + ((bcode[0x19] << 8) | bcode[0x18]);
+-              qla24xx_read_flash_data(vha, dcode, pcids >> 2, 0x20);
++              rc = qla24xx_read_flash_data(vha, dcode, pcids >> 2, 0x20);
++              if (rc) {
++                      ql_log(ql_log_info, vha, 0x0179,
++                          "Unable to read PCI Data Structure (%x).\n", rc);
++                      return QLA_FUNCTION_FAILED;
++              }
+               bcode = buf + (pcihdr % 4);
+               /* Validate signature of PCI data structure. */
+@@ -606,7 +617,12 @@ qla2xxx_find_flt_start(scsi_qla_host_t *
+       } while (!last_image);
+       /* Now verify FLT-location structure. */
+-      qla24xx_read_flash_data(vha, dcode, pcihdr >> 2, sizeof(*fltl) >> 2);
++      rc = qla24xx_read_flash_data(vha, dcode, pcihdr >> 2, sizeof(*fltl) >> 2);
++      if (rc) {
++              ql_log(ql_log_info, vha, 0x017a,
++                  "Unable to read FLT (%x).\n", rc);
++              return QLA_FUNCTION_FAILED;
++      }
+       if (memcmp(fltl->sig, "QFLT", 4))
+               goto end;
+@@ -2605,13 +2621,18 @@ qla24xx_read_optrom_data(struct scsi_qla
+     uint32_t offset, uint32_t length)
+ {
+       struct qla_hw_data *ha = vha->hw;
++      int rc;
+       /* Suspend HBA. */
+       scsi_block_requests(vha->host);
+       set_bit(MBX_UPDATE_FLASH_ACTIVE, &ha->mbx_cmd_flags);
+       /* Go with read. */
+-      qla24xx_read_flash_data(vha, buf, offset >> 2, length >> 2);
++      rc = qla24xx_read_flash_data(vha, buf, offset >> 2, length >> 2);
++      if (rc) {
++              ql_log(ql_log_info, vha, 0x01a0,
++                  "Unable to perform optrom read(%x).\n", rc);
++      }
+       /* Resume HBA. */
+       clear_bit(MBX_UPDATE_FLASH_ACTIVE, &ha->mbx_cmd_flags);
+@@ -3412,7 +3433,7 @@ qla24xx_get_flash_version(scsi_qla_host_
+       struct active_regions active_regions = { };
+       if (IS_P3P_TYPE(ha))
+-              return ret;
++              return QLA_SUCCESS;
+       if (!mbuf)
+               return QLA_FUNCTION_FAILED;
+@@ -3432,20 +3453,31 @@ qla24xx_get_flash_version(scsi_qla_host_
+       do {
+               /* Verify PCI expansion ROM header. */
+-              qla24xx_read_flash_data(vha, dcode, pcihdr >> 2, 0x20);
++              ret = qla24xx_read_flash_data(vha, dcode, pcihdr >> 2, 0x20);
++              if (ret) {
++                      ql_log(ql_log_info, vha, 0x017d,
++                          "Unable to read PCI EXP Rom Header(%x).\n", ret);
++                      return QLA_FUNCTION_FAILED;
++              }
++
+               bcode = mbuf + (pcihdr % 4);
+               if (memcmp(bcode, "\x55\xaa", 2)) {
+                       /* No signature */
+                       ql_log(ql_log_fatal, vha, 0x0059,
+                           "No matching ROM signature.\n");
+-                      ret = QLA_FUNCTION_FAILED;
+-                      break;
++                      return QLA_FUNCTION_FAILED;
+               }
+               /* Locate PCI data structure. */
+               pcids = pcihdr + ((bcode[0x19] << 8) | bcode[0x18]);
+-              qla24xx_read_flash_data(vha, dcode, pcids >> 2, 0x20);
++              ret = qla24xx_read_flash_data(vha, dcode, pcids >> 2, 0x20);
++              if (ret) {
++                      ql_log(ql_log_info, vha, 0x018e,
++                          "Unable to read PCI Data Structure (%x).\n", ret);
++                      return QLA_FUNCTION_FAILED;
++              }
++
+               bcode = mbuf + (pcihdr % 4);
+               /* Validate signature of PCI data structure. */
+@@ -3454,8 +3486,7 @@ qla24xx_get_flash_version(scsi_qla_host_
+                       ql_log(ql_log_fatal, vha, 0x005a,
+                           "PCI data struct not found pcir_adr=%x.\n", pcids);
+                       ql_dump_buffer(ql_dbg_init, vha, 0x0059, dcode, 32);
+-                      ret = QLA_FUNCTION_FAILED;
+-                      break;
++                      return QLA_FUNCTION_FAILED;
+               }
+               /* Read version */
+@@ -3507,20 +3538,26 @@ qla24xx_get_flash_version(scsi_qla_host_
+                       faddr = ha->flt_region_fw_sec;
+       }
+-      qla24xx_read_flash_data(vha, dcode, faddr, 8);
+-      if (qla24xx_risc_firmware_invalid(dcode)) {
+-              ql_log(ql_log_warn, vha, 0x005f,
+-                  "Unrecognized fw revision at %x.\n",
+-                  ha->flt_region_fw * 4);
+-              ql_dump_buffer(ql_dbg_init, vha, 0x005f, dcode, 32);
++      ret = qla24xx_read_flash_data(vha, dcode, faddr, 8);
++      if (ret) {
++              ql_log(ql_log_info, vha, 0x019e,
++                  "Unable to read FW version (%x).\n", ret);
++              return ret;
+       } else {
+-              for (i = 0; i < 4; i++)
+-                      ha->fw_revision[i] =
++              if (qla24xx_risc_firmware_invalid(dcode)) {
++                      ql_log(ql_log_warn, vha, 0x005f,
++                          "Unrecognized fw revision at %x.\n",
++                          ha->flt_region_fw * 4);
++                      ql_dump_buffer(ql_dbg_init, vha, 0x005f, dcode, 32);
++              } else {
++                      for (i = 0; i < 4; i++)
++                              ha->fw_revision[i] =
+                               be32_to_cpu((__force __be32)dcode[4+i]);
+-              ql_dbg(ql_dbg_init, vha, 0x0060,
+-                  "Firmware revision (flash) %u.%u.%u (%x).\n",
+-                  ha->fw_revision[0], ha->fw_revision[1],
+-                  ha->fw_revision[2], ha->fw_revision[3]);
++                      ql_dbg(ql_dbg_init, vha, 0x0060,
++                          "Firmware revision (flash) %u.%u.%u (%x).\n",
++                          ha->fw_revision[0], ha->fw_revision[1],
++                          ha->fw_revision[2], ha->fw_revision[3]);
++              }
+       }
+       /* Check for golden firmware and get version if available */
+@@ -3531,18 +3568,23 @@ qla24xx_get_flash_version(scsi_qla_host_
+       memset(ha->gold_fw_version, 0, sizeof(ha->gold_fw_version));
+       faddr = ha->flt_region_gold_fw;
+-      qla24xx_read_flash_data(vha, dcode, ha->flt_region_gold_fw, 8);
+-      if (qla24xx_risc_firmware_invalid(dcode)) {
+-              ql_log(ql_log_warn, vha, 0x0056,
+-                  "Unrecognized golden fw at %#x.\n", faddr);
+-              ql_dump_buffer(ql_dbg_init, vha, 0x0056, dcode, 32);
++      ret = qla24xx_read_flash_data(vha, dcode, ha->flt_region_gold_fw, 8);
++      if (ret) {
++              ql_log(ql_log_info, vha, 0x019f,
++                  "Unable to read Gold FW version (%x).\n", ret);
+               return ret;
+-      }
+-
+-      for (i = 0; i < 4; i++)
+-              ha->gold_fw_version[i] =
+-                      be32_to_cpu((__force __be32)dcode[4+i]);
++      } else {
++              if (qla24xx_risc_firmware_invalid(dcode)) {
++                      ql_log(ql_log_warn, vha, 0x0056,
++                          "Unrecognized golden fw at %#x.\n", faddr);
++                      ql_dump_buffer(ql_dbg_init, vha, 0x0056, dcode, 32);
++                      return QLA_FUNCTION_FAILED;
++              }
++              for (i = 0; i < 4; i++)
++                      ha->gold_fw_version[i] =
++                         be32_to_cpu((__force __be32)dcode[4+i]);
++      }
+       return ret;
+ }
diff --git a/queue-5.10/scsi-qla2xxx-fix-for-possible-memory-corruption.patch b/queue-5.10/scsi-qla2xxx-fix-for-possible-memory-corruption.patch
new file mode 100644 (file)
index 0000000..7fb79c4
--- /dev/null
@@ -0,0 +1,33 @@
+From c03d740152f78e86945a75b2ad541bf972fab92a Mon Sep 17 00:00:00 2001
+From: Shreyas Deodhar <sdeodhar@marvell.com>
+Date: Wed, 10 Jul 2024 22:40:49 +0530
+Subject: scsi: qla2xxx: Fix for possible memory corruption
+
+From: Shreyas Deodhar <sdeodhar@marvell.com>
+
+commit c03d740152f78e86945a75b2ad541bf972fab92a upstream.
+
+Init Control Block is dereferenced incorrectly.  Correctly dereference ICB
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Shreyas Deodhar <sdeodhar@marvell.com>
+Signed-off-by: Nilesh Javali <njavali@marvell.com>
+Link: https://lore.kernel.org/r/20240710171057.35066-4-njavali@marvell.com
+Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
+Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/scsi/qla2xxx/qla_os.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/scsi/qla2xxx/qla_os.c
++++ b/drivers/scsi/qla2xxx/qla_os.c
+@@ -4453,7 +4453,7 @@ static void
+ qla2x00_number_of_exch(scsi_qla_host_t *vha, u32 *ret_cnt, u16 max_cnt)
+ {
+       u32 temp;
+-      struct init_cb_81xx *icb = (struct init_cb_81xx *)&vha->hw->init_cb;
++      struct init_cb_81xx *icb = (struct init_cb_81xx *)vha->hw->init_cb;
+       *ret_cnt = FW_DEF_EXCHANGES_CNT;
+       if (max_cnt > vha->hw->max_exchg)
diff --git a/queue-5.10/scsi-qla2xxx-validate-nvme_local_port-correctly.patch b/queue-5.10/scsi-qla2xxx-validate-nvme_local_port-correctly.patch
new file mode 100644 (file)
index 0000000..8c5971e
--- /dev/null
@@ -0,0 +1,60 @@
+From eb1d4ce2609584eeb7694866f34d4b213caa3af9 Mon Sep 17 00:00:00 2001
+From: Nilesh Javali <njavali@marvell.com>
+Date: Wed, 10 Jul 2024 22:40:48 +0530
+Subject: scsi: qla2xxx: validate nvme_local_port correctly
+
+From: Nilesh Javali <njavali@marvell.com>
+
+commit eb1d4ce2609584eeb7694866f34d4b213caa3af9 upstream.
+
+The driver load failed with error message,
+
+qla2xxx [0000:04:00.0]-ffff:0: register_localport failed: ret=ffffffef
+
+and with a kernel crash,
+
+       BUG: unable to handle kernel NULL pointer dereference at 0000000000000070
+       Workqueue: events_unbound qla_register_fcport_fn [qla2xxx]
+       RIP: 0010:nvme_fc_register_remoteport+0x16/0x430 [nvme_fc]
+       RSP: 0018:ffffaaa040eb3d98 EFLAGS: 00010282
+       RAX: 0000000000000000 RBX: ffff9dfb46b78c00 RCX: 0000000000000000
+       RDX: ffff9dfb46b78da8 RSI: ffffaaa040eb3e08 RDI: 0000000000000000
+       RBP: ffff9dfb612a0a58 R08: ffffffffaf1d6270 R09: 3a34303a30303030
+       R10: 34303a303030305b R11: 2078787832616c71 R12: ffff9dfb46b78dd4
+       R13: ffff9dfb46b78c24 R14: ffff9dfb41525300 R15: ffff9dfb46b78da8
+       FS:  0000000000000000(0000) GS:ffff9dfc67c00000(0000) knlGS:0000000000000000
+       CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
+       CR2: 0000000000000070 CR3: 000000018da10004 CR4: 00000000000206f0
+       Call Trace:
+       qla_nvme_register_remote+0xeb/0x1f0 [qla2xxx]
+       ? qla2x00_dfs_create_rport+0x231/0x270 [qla2xxx]
+       qla2x00_update_fcport+0x2a1/0x3c0 [qla2xxx]
+       qla_register_fcport_fn+0x54/0xc0 [qla2xxx]
+
+Exit the qla_nvme_register_remote() function when qla_nvme_register_hba()
+fails and correctly validate nvme_local_port.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Nilesh Javali <njavali@marvell.com>
+Link: https://lore.kernel.org/r/20240710171057.35066-3-njavali@marvell.com
+Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
+Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/scsi/qla2xxx/qla_nvme.c |    5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+--- a/drivers/scsi/qla2xxx/qla_nvme.c
++++ b/drivers/scsi/qla2xxx/qla_nvme.c
+@@ -27,7 +27,10 @@ int qla_nvme_register_remote(struct scsi
+               return 0;
+       }
+-      if (!vha->nvme_local_port && qla_nvme_register_hba(vha))
++      if (qla_nvme_register_hba(vha))
++              return 0;
++
++      if (!vha->nvme_local_port)
+               return 0;
+       if (!(fcport->nvme_prli_service_param &
index cdc1db2fa112836f1fc3fd6cd8a6c1334e24af42..068d10d0bea81132d4e90037d448f095391b169e 100644 (file)
@@ -163,3 +163,13 @@ kbuild-fix-s-c-in-x86-stack-protector-scripts.patch
 kobject_uevent-fix-oob-access-within-zap_modalias_env.patch
 devres-fix-devm_krealloc-wasting-memory.patch
 rtc-cmos-fix-return-value-of-nvmem-callbacks.patch
+scsi-qla2xxx-during-vport-delete-send-async-logout-explicitly.patch
+scsi-qla2xxx-fix-for-possible-memory-corruption.patch
+scsi-qla2xxx-fix-flash-read-failure.patch
+scsi-qla2xxx-complete-command-early-within-lock.patch
+scsi-qla2xxx-validate-nvme_local_port-correctly.patch
+perf-x86-intel-pt-fix-topa_entry-base-length.patch
+perf-x86-intel-pt-fix-a-topa_entry-base-address-calculation.patch
+rtc-isl1208-fix-return-value-of-nvmem-callbacks.patch
+watchdog-perf-properly-initialize-the-turbo-mode-timestamp-and-rearm-counter.patch
+platform-mips-cpu_hwmon-disable-driver-on-unsupported-hardware.patch
diff --git a/queue-5.10/watchdog-perf-properly-initialize-the-turbo-mode-timestamp-and-rearm-counter.patch b/queue-5.10/watchdog-perf-properly-initialize-the-turbo-mode-timestamp-and-rearm-counter.patch
new file mode 100644 (file)
index 0000000..2340937
--- /dev/null
@@ -0,0 +1,68 @@
+From f944ffcbc2e1c759764850261670586ddf3bdabb Mon Sep 17 00:00:00 2001
+From: Thomas Gleixner <tglx@linutronix.de>
+Date: Thu, 11 Jul 2024 22:25:21 +0200
+Subject: watchdog/perf: properly initialize the turbo mode timestamp and rearm counter
+
+From: Thomas Gleixner <tglx@linutronix.de>
+
+commit f944ffcbc2e1c759764850261670586ddf3bdabb upstream.
+
+For systems on which the performance counter can expire early due to turbo
+modes the watchdog handler has a safety net in place which validates that
+since the last watchdog event there has at least 4/5th of the watchdog
+period elapsed.
+
+This works reliably only after the first watchdog event because the per
+CPU variable which holds the timestamp of the last event is never
+initialized.
+
+So a first spurious event will validate against a timestamp of 0 which
+results in a delta which is likely to be way over the 4/5 threshold of the
+period.  As this might happen before the first watchdog hrtimer event
+increments the watchdog counter, this can lead to false positives.
+
+Fix this by initializing the timestamp before enabling the hardware event.
+Reset the rearm counter as well, as that might be non zero after the
+watchdog was disabled and reenabled.
+
+Link: https://lkml.kernel.org/r/87frsfu15a.ffs@tglx
+Fixes: 7edaeb6841df ("kernel/watchdog: Prevent false positives with turbo modes")
+Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
+Cc: Arjan van de Ven <arjan@linux.intel.com>
+Cc: Peter Zijlstra <peterz@infradead.org>
+Cc: <stable@vger.kernel.org>
+Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ kernel/watchdog_hld.c |   11 ++++++++---
+ 1 file changed, 8 insertions(+), 3 deletions(-)
+
+--- a/kernel/watchdog_hld.c
++++ b/kernel/watchdog_hld.c
+@@ -91,11 +91,15 @@ static bool watchdog_check_timestamp(voi
+       __this_cpu_write(last_timestamp, now);
+       return true;
+ }
+-#else
+-static inline bool watchdog_check_timestamp(void)
++
++static void watchdog_init_timestamp(void)
+ {
+-      return true;
++      __this_cpu_write(nmi_rearmed, 0);
++      __this_cpu_write(last_timestamp, ktime_get_mono_fast_ns());
+ }
++#else
++static inline bool watchdog_check_timestamp(void) { return true; }
++static inline void watchdog_init_timestamp(void) { }
+ #endif
+ static struct perf_event_attr wd_hw_attr = {
+@@ -196,6 +200,7 @@ void hardlockup_detector_perf_enable(voi
+       if (!atomic_fetch_inc(&watchdog_cpus))
+               pr_info("Enabled. Permanently consumes one hw-PMU counter.\n");
++      watchdog_init_timestamp();
+       perf_event_enable(this_cpu_read(watchdog_ev));
+ }