]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath12k: remove warning print in htt mlo offset event message
authorAditya Kumar Singh <quic_adisi@quicinc.com>
Wed, 11 Dec 2024 15:43:55 +0000 (17:43 +0200)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Mon, 16 Dec 2024 20:46:58 +0000 (12:46 -0800)
In the function ath12k_htt_mlo_offset_event_handler(), it is possible that
the ar is not yet active (started). The function
ath12k_mac_get_ar_by_pdev_id() only searches for active pdev, so a NULL
return is possible. Therefore, there is no need to print a warning,
instead, just silently discard the message.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://patch.msgid.link/20241211154358.776279-5-kvalo@kernel.org
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/dp_rx.c

index 66367bfb4acc9a0cf1e73219506fcdd417dc199c..5c5a3aae393be52a241c048c5a60c57d1f8cea92 100644 (file)
@@ -1697,7 +1697,11 @@ static void ath12k_htt_mlo_offset_event_handler(struct ath12k_base *ab,
        rcu_read_lock();
        ar = ath12k_mac_get_ar_by_pdev_id(ab, pdev_id);
        if (!ar) {
-               ath12k_warn(ab, "invalid pdev id %d on htt mlo offset\n", pdev_id);
+               /* It is possible that the ar is not yet active (started).
+                * The above function will only look for the active pdev
+                * and hence %NULL return is possible. Just silently
+                * discard this message
+                */
                goto exit;
        }