]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soundwire: bus: demote UNATTACHED state warnings to dev_dbg()
authorCole Leavitt <cole@unwrap.rs>
Wed, 18 Feb 2026 18:02:10 +0000 (11:02 -0700)
committerVinod Koul <vkoul@kernel.org>
Mon, 9 Mar 2026 07:03:20 +0000 (08:03 +0100)
The dev_warn() messages in sdw_handle_slave_status() for UNATTACHED
transitions were added in commit d1b328557058 ("soundwire: bus: add
dev_warn() messages to track UNATTACHED devices") to debug attachment
failures with dynamic debug enabled.

These warnings fire during normal operation -- for example when a codec
driver triggers a hardware reset after firmware download, causing the
device to momentarily go UNATTACHED before re-attaching -- producing
misleading noise on every boot.

Demote the messages to dev_dbg() so they remain available via dynamic
debug for diagnosing real attachment failures without alarming users
during expected initialization sequences.

Fixes: d1b328557058 ("soundwire: bus: add dev_warn() messages to track UNATTACHED devices")
Signed-off-by: Cole Leavitt <cole@unwrap.rs>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://patch.msgid.link/20260218180210.9263-1-cole@unwrap.rs
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/bus.c

index fb68738dfb9b8447b0c03f3bd4cfbec4cea7504d..fe5316d93fefe7f2b49d788352f7bdd41b878fd0 100644 (file)
@@ -1899,8 +1899,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
 
                if (status[i] == SDW_SLAVE_UNATTACHED &&
                    slave->status != SDW_SLAVE_UNATTACHED) {
-                       dev_warn(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\n",
-                                i, slave->status);
+                       dev_dbg(&slave->dev, "Slave %d state check1: UNATTACHED, status was %d\n",
+                       i, slave->status);
                        sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED);
 
                        /* Ensure driver knows that peripheral unattached */
@@ -1951,8 +1951,8 @@ int sdw_handle_slave_status(struct sdw_bus *bus,
                        if (slave->status == SDW_SLAVE_UNATTACHED)
                                break;
 
-                       dev_warn(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\n",
-                                i, slave->status);
+                       dev_dbg(&slave->dev, "Slave %d state check2: UNATTACHED, status was %d\n",
+                       i, slave->status);
 
                        sdw_modify_slave_status(slave, SDW_SLAVE_UNATTACHED);
                        break;