]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/cx0: s/XELPDP_MSGBUS_TIMEOUT_SLOW/XELPDP_MSGBUS_TIMEOUT_MS/
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 6 Nov 2025 15:20:45 +0000 (17:20 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 7 Nov 2025 18:29:43 +0000 (20:29 +0200)
The slow vs. fast timeout stuff is really just an implementation
detail. Let's not spread that terminology in random timeout defines.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20251106152049.21115-7-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_cx0_phy.c
drivers/gpu/drm/i915/display/intel_cx0_phy_regs.h
drivers/gpu/drm/i915/display/intel_lt_phy.c

index ddcfdf45bd38cb69395fe6fd05deda0b342a4b8d..dd1429fa5028b0493266b9f20c25b2d31b101899 100644 (file)
@@ -147,7 +147,7 @@ void intel_cx0_bus_reset(struct intel_encoder *encoder, int lane)
 
        if (intel_de_wait_for_clear(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane),
                                    XELPDP_PORT_M2P_TRANSACTION_RESET,
-                                   XELPDP_MSGBUS_TIMEOUT_SLOW)) {
+                                   XELPDP_MSGBUS_TIMEOUT_MS)) {
                drm_err_once(display->drm,
                             "Failed to bring PHY %c to idle.\n",
                             phy_name(phy));
@@ -168,7 +168,7 @@ int intel_cx0_wait_for_ack(struct intel_encoder *encoder,
                                 XELPDP_PORT_P2M_MSGBUS_STATUS(display, port, lane),
                                 XELPDP_PORT_P2M_RESPONSE_READY,
                                 XELPDP_PORT_P2M_RESPONSE_READY,
-                                2, XELPDP_MSGBUS_TIMEOUT_SLOW, val)) {
+                                2, XELPDP_MSGBUS_TIMEOUT_MS, val)) {
                drm_dbg_kms(display->drm,
                            "PHY %c Timeout waiting for message ACK. Status: 0x%x\n",
                            phy_name(phy), *val);
@@ -215,7 +215,7 @@ static int __intel_cx0_read_once(struct intel_encoder *encoder,
 
        if (intel_de_wait_for_clear(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane),
                                    XELPDP_PORT_M2P_TRANSACTION_PENDING,
-                                   XELPDP_MSGBUS_TIMEOUT_SLOW)) {
+                                   XELPDP_MSGBUS_TIMEOUT_MS)) {
                drm_dbg_kms(display->drm,
                            "PHY %c Timeout waiting for previous transaction to complete. Reset the bus and retry.\n", phy_name(phy));
                intel_cx0_bus_reset(encoder, lane);
@@ -286,7 +286,7 @@ static int __intel_cx0_write_once(struct intel_encoder *encoder,
 
        if (intel_de_wait_for_clear(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane),
                                    XELPDP_PORT_M2P_TRANSACTION_PENDING,
-                                   XELPDP_MSGBUS_TIMEOUT_SLOW)) {
+                                   XELPDP_MSGBUS_TIMEOUT_MS)) {
                drm_dbg_kms(display->drm,
                            "PHY %c Timeout waiting for previous transaction to complete. Resetting the bus.\n", phy_name(phy));
                intel_cx0_bus_reset(encoder, lane);
@@ -302,7 +302,7 @@ static int __intel_cx0_write_once(struct intel_encoder *encoder,
 
        if (intel_de_wait_for_clear(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane),
                                    XELPDP_PORT_M2P_TRANSACTION_PENDING,
-                                   XELPDP_MSGBUS_TIMEOUT_SLOW)) {
+                                   XELPDP_MSGBUS_TIMEOUT_MS)) {
                drm_dbg_kms(display->drm,
                            "PHY %c Timeout waiting for write to complete. Resetting the bus.\n", phy_name(phy));
                intel_cx0_bus_reset(encoder, lane);
@@ -2815,7 +2815,7 @@ void intel_cx0_powerdown_change_sequence(struct intel_encoder *encoder,
        for_each_cx0_lane_in_mask(lane_mask, lane)
                if (intel_de_wait_for_clear(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane),
                                            XELPDP_PORT_M2P_TRANSACTION_PENDING,
-                                           XELPDP_MSGBUS_TIMEOUT_SLOW)) {
+                                           XELPDP_MSGBUS_TIMEOUT_MS)) {
                        drm_dbg_kms(display->drm,
                                    "PHY %c Timeout waiting for previous transaction to complete. Reset the bus.\n",
                                    phy_name(phy));
index f031de40f6c6c2947ae129a99bbf8cccc6633ee7..715ca004516aafe64408e790e6c76085cc1075cb 100644 (file)
@@ -74,7 +74,7 @@
 #define   XELPDP_PORT_P2M_DATA(val)                    REG_FIELD_PREP(XELPDP_PORT_P2M_DATA_MASK, val)
 #define   XELPDP_PORT_P2M_ERROR_SET                    REG_BIT(15)
 
-#define XELPDP_MSGBUS_TIMEOUT_SLOW                     1
+#define XELPDP_MSGBUS_TIMEOUT_MS                       1
 #define XELPDP_PCLK_PLL_ENABLE_TIMEOUT_US              3200
 #define XELPDP_PCLK_PLL_DISABLE_TIMEOUT_US             20
 #define XELPDP_PORT_BUF_SOC_READY_TIMEOUT_US           100
index 8ab632965033079649e273abc92a2a8ddc67ab42..ff5af9c25e6d0bfdf8b9a9a4a6a1dc54b8eaf82b 100644 (file)
@@ -1043,7 +1043,7 @@ static int __intel_lt_phy_p2p_write_once(struct intel_encoder *encoder,
 
        if (intel_de_wait_for_clear(display, XELPDP_PORT_M2P_MSGBUS_CTL(display, port, lane),
                                    XELPDP_PORT_P2P_TRANSACTION_PENDING,
-                                   XELPDP_MSGBUS_TIMEOUT_SLOW)) {
+                                   XELPDP_MSGBUS_TIMEOUT_MS)) {
                drm_dbg_kms(display->drm,
                            "PHY %c Timeout waiting for previous transaction to complete. Resetting bus.\n",
                            phy_name(phy));