]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
boot: use cleanup-based file handle closing a bit more
authorLennart Poettering <lennart@poettering.net>
Fri, 17 Sep 2021 08:32:33 +0000 (10:32 +0200)
committerLennart Poettering <lennart@poettering.net>
Mon, 20 Sep 2021 20:18:03 +0000 (22:18 +0200)
src/boot/efi/boot.c

index cfe20c27f809eff81d8f72f8dec6c512ea73c49e..106fda925cbc92283d01d0f73a2156170ed94a69 100644 (file)
@@ -1492,7 +1492,7 @@ static VOID config_load_entries(
                 EFI_FILE *root_dir,
                 CHAR16 *loaded_image_path) {
 
-        EFI_FILE_HANDLE entries_dir;
+        _cleanup_(FileHandleClosep) EFI_FILE_HANDLE entries_dir = NULL;
         EFI_STATUS err;
 
         assert(config);
@@ -1530,8 +1530,6 @@ static VOID config_load_entries(
                 if (!EFI_ERROR(err))
                         config_entry_add_from_file(config, device, root_dir, L"\\loader\\entries", f->FileName, content, loaded_image_path);
         }
-
-        uefi_call_wrapper(entries_dir->Close, 1, entries_dir);
 }
 
 static INTN config_entry_compare(ConfigEntry *a, ConfigEntry *b) {
@@ -1982,7 +1980,7 @@ static VOID config_entry_add_linux(
                 EFI_HANDLE *device,
                 EFI_FILE *root_dir) {
 
-        EFI_FILE_HANDLE linux_dir;
+        _cleanup_(FileHandleClosep) EFI_FILE_HANDLE linux_dir = NULL;
         EFI_STATUS err;
         ConfigEntry *entry;
 
@@ -2112,8 +2110,6 @@ static VOID config_entry_add_linux(
                 FreePool(os_build_id);
                 FreePool(content);
         }
-
-        uefi_call_wrapper(linux_dir->Close, 1, linux_dir);
 }
 
 #define XBOOTLDR_GUID \