]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
libsystemd: drop unexported sd-utf8
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Sun, 12 Jun 2022 20:09:49 +0000 (22:09 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Thu, 30 Jun 2022 08:35:26 +0000 (10:35 +0200)
It had two symbols which were not actually exported because they were not
listed in libsystemd.sym. They were also entirely unused in our codebase.
I don't think it makes much sense to export just those two functions, and
it doesn't make to build a string processing library in systemd either.

History of the file shows that it was created in
faaa5728d956b7f0d24f27f3341d0b9fff30af00 'utf8: export utf8 validation functions as part of sd-bus'
and hasn't gone even one non-trivial change since then ;)

src/libsystemd/meson.build
src/libsystemd/sd-utf8/sd-utf8.c [deleted file]
src/systemd/meson.build

index 055fa11ede75a83ff907bb4f3599c3e5620952f7..2b288ccb2884a8e0b9c8883825f7f27d7694db01 100644 (file)
@@ -155,7 +155,6 @@ libsystemd_sources = files(
         'sd-path/sd-path.c',
         'sd-resolve/resolve-private.h',
         'sd-resolve/sd-resolve.c',
-        'sd-utf8/sd-utf8.c',
 ) + sd_journal_sources + id128_sources + sd_daemon_sources + sd_event_sources + sd_login_sources
 
 
diff --git a/src/libsystemd/sd-utf8/sd-utf8.c b/src/libsystemd/sd-utf8/sd-utf8.c
deleted file mode 100644 (file)
index 82fa125..0000000
+++ /dev/null
@@ -1,18 +0,0 @@
-/* SPDX-License-Identifier: LGPL-2.1-or-later */
-
-#include "sd-utf8.h"
-
-#include "utf8.h"
-#include "util.h"
-
-_public_ const char *sd_utf8_is_valid(const char *s) {
-        assert_return(s, NULL);
-
-        return utf8_is_valid(s);
-}
-
-_public_ const char *sd_ascii_is_valid(const char *s) {
-        assert_return(s, NULL);
-
-        return ascii_is_valid(s);
-}
index df8c74ebdd06069523a1ce17211daa8ee870018b..6048c138597b88694db304d79876bfc7aa7dac79 100644 (file)
@@ -36,7 +36,6 @@ _not_installed_headers = [
         'sd-network.h',
         'sd-radv.h',
         'sd-resolve.h',
-        'sd-utf8.h',
 ]
 
 install_headers(