]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
fuzz-journal-remote: print some kinds of errors 19766/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 31 May 2021 10:05:29 +0000 (12:05 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 31 May 2021 17:29:07 +0000 (19:29 +0200)
In https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34803, we fail with:

  Assertion 'IN_SET(r, -ENOMEM, -EMFILE, -ENFILE)' failed at src/journal-remote/fuzz-journal-remote.c:69,
    function int LLVMFuzzerTestOneInput(const uint8_t *, size_t)(). Aborting.
  AddressSanitizer:DEADLYSIGNAL

Let's try to print the error, so maybe we can see what is going on.
With the previous commit we shouldn't print out anything.

src/journal-remote/fuzz-journal-remote.c

index 37eff2f748bbcd93844b14044ee3e5a498097c1f..32c4e1819ca6313a65f1e1f94fe5b5697a3af30e 100644 (file)
@@ -28,7 +28,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
                 return 0;
 
         if (!getenv("SYSTEMD_LOG_LEVEL"))
-                log_set_max_level(LOG_CRIT);
+                log_set_max_level(LOG_ERR);
 
         fdin = memfd_new_and_map("fuzz-journal-remote", size, &mem);
         if (fdin < 0)
@@ -66,6 +66,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
 
         r = sd_journal_open_files(&j, (const char**) STRV_MAKE(name), 0);
         if (r < 0) {
+                log_error_errno(r, "sd_journal_open_files([\"%s\"]) failed: %m", name);
                 assert_se(IN_SET(r, -ENOMEM, -EMFILE, -ENFILE));
                 return r;
         }