]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Initialize pointer with NULL
authorAndreas Schneider <asn@samba.org>
Tue, 16 Jul 2024 08:33:38 +0000 (10:33 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 18 Jul 2024 12:47:29 +0000 (12:47 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/smb2/durable_open.c:1447: var_decl: Declaring variable ""tree2"" without initializer.
samba-4.20.0rc2/source4/torture/smb2/durable_open.c:1492: uninit_use_in_call: Using uninitialized value ""tree2"" when calling ""smb2_util_unlink"".
 1490|    }
 1491|
 1492|->  smb2_util_unlink(tree2, fname);
 1493|
 1494|    talloc_free(tree);"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
source4/torture/smb2/durable_open.c

index e4513cf4155064ab3191d0b2fc81306874c7bc1f..cd07b330484e7a230daa84f518360f16b6e72dff 100644 (file)
@@ -1444,7 +1444,7 @@ static bool test_durable_open_reopen3(struct torture_context *tctx,
        struct smb2_handle *h = NULL;
        struct smb2_create io1, io2;
        bool ret = true;
-       struct smb2_tree *tree2;
+       struct smb2_tree *tree2 = NULL;
 
        /* Choose a random name in case the state is left a little funky. */
        snprintf(fname, 256, "durable_open_reopen3_%s.dat",