]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test-web-util.c: Migrate to new assertion MACROs
authorYaping Li <202858510+YapingLi04@users.noreply.github.com>
Thu, 17 Jul 2025 01:48:58 +0000 (18:48 -0700)
committerLuca Boccassi <luca.boccassi@gmail.com>
Fri, 18 Jul 2025 19:00:40 +0000 (20:00 +0100)
We recently added a new set of assertion macros such as ASSERT_GE, ASSERT_OK, ASSERT_EQ, ... which show not
only the expression that failed but also the values of the arguments of the expression. Let's use them.

src/test/test-web-util.c

index bb05f372766190f3090030190624c65a009f8337..82aac6d8e2f5d7c0c091e53f628df503e5c58c30 100644 (file)
@@ -4,17 +4,17 @@
 #include "web-util.h"
 
 TEST(is_valid_documentation_url) {
-        assert_se(documentation_url_is_valid("https://www.freedesktop.org/wiki/Software/systemd"));
-        assert_se(documentation_url_is_valid("https://www.kernel.org/doc/Documentation/binfmt_misc.txt"));  /* dead */
-        assert_se(documentation_url_is_valid("https://www.kernel.org/doc/Documentation/admin-guide/binfmt-misc.rst"));
-        assert_se(documentation_url_is_valid("https://docs.kernel.org/admin-guide/binfmt-misc.html"));
-        assert_se(documentation_url_is_valid("file:/foo/foo"));
-        assert_se(documentation_url_is_valid("man:systemd.special(7)"));
-        assert_se(documentation_url_is_valid("info:bar"));
+        ASSERT_TRUE(documentation_url_is_valid("https://www.freedesktop.org/wiki/Software/systemd"));
+        ASSERT_TRUE(documentation_url_is_valid("https://www.kernel.org/doc/Documentation/binfmt_misc.txt"));  /* dead */
+        ASSERT_TRUE(documentation_url_is_valid("https://www.kernel.org/doc/Documentation/admin-guide/binfmt-misc.rst"));
+        ASSERT_TRUE(documentation_url_is_valid("https://docs.kernel.org/admin-guide/binfmt-misc.html"));
+        ASSERT_TRUE(documentation_url_is_valid("file:/foo/foo"));
+        ASSERT_TRUE(documentation_url_is_valid("man:systemd.special(7)"));
+        ASSERT_TRUE(documentation_url_is_valid("info:bar"));
 
-        assert_se(!documentation_url_is_valid("foo:"));
-        assert_se(!documentation_url_is_valid("info:"));
-        assert_se(!documentation_url_is_valid(""));
+        ASSERT_TRUE(!documentation_url_is_valid("foo:"));
+        ASSERT_TRUE(!documentation_url_is_valid("info:"));
+        ASSERT_TRUE(!documentation_url_is_valid(""));
 }
 
 DEFINE_TEST_MAIN(LOG_INFO);