]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
growfs: insist we open a directory when opening fs mount point
authorLennart Poettering <lennart@poettering.net>
Thu, 14 Jul 2022 09:30:27 +0000 (11:30 +0200)
committerLennart Poettering <lennart@poettering.net>
Thu, 14 Jul 2022 09:30:27 +0000 (11:30 +0200)
This is a simple safety check, since we shouldn't invoke ioctls on fds
without being reasonably sure they are of the right type since ioctls
are overloaded, and we might be tricked hence to execute an operation on
an fd which means something different than what we expect.

src/partition/growfs.c

index 31dcf0ffdf14f47c3f00bc85d816789e66994c32..d7069b8d0824f04b8eefd3f2da963943280bb725 100644 (file)
@@ -225,7 +225,7 @@ static int run(int argc, char *argv[]) {
         if (r < 0)
                 return r;
 
-        mountfd = open(arg_target, O_RDONLY|O_CLOEXEC);
+        mountfd = open(arg_target, O_RDONLY|O_CLOEXEC|O_DIRECTORY);
         if (mountfd < 0)
                 return log_error_errno(errno, "Failed to open \"%s\": %m", arg_target);