]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
data_smart: Separate out update_overridevars into separate function
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 16 Sep 2015 20:54:42 +0000 (21:54 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 16 Sep 2015 21:02:18 +0000 (22:02 +0100)
No code changes, just refactoring to allow for functionality
changes by moving things to a separate function.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
lib/bb/data_smart.py

index 79b4ed932976ebbddd3ec635bffbf443312ae31f..4be6614a2f6e337a44d6459f1c6048ffe75e4403 100644 (file)
@@ -484,10 +484,8 @@ class DataSmart(MutableMapping):
             if '_' in var:
                 self._setvar_update_overrides(base, **loginfo)
 
-
             if base in self.overridevars:
-                self.overridevars.update(self.expandWithRefs(value, var).references)
-                self.internal_finalize(True)
+                self._setvar_update_overridevars(var, value)
             return
 
         if not var in self.dict:
@@ -520,8 +518,11 @@ class DataSmart(MutableMapping):
         self.varhistory.record(**loginfo)
 
         if var in self.overridevars:
-            self.overridevars.update(self.expandWithRefs(value, var).references)
-            self.internal_finalize(True)
+            self._setvar_update_overridevars(var, value)
+
+    def _setvar_update_overridevars(self, var, value):
+        self.overridevars.update(self.expandWithRefs(value, var).references)
+        self.internal_finalize(True)
 
     def _setvar_update_overrides(self, var, **loginfo):
         # aka pay the cookie monster