]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: max77650: fix OF node reference imbalance
authorJohan Hovold <johan@kernel.org>
Wed, 8 Apr 2026 07:30:51 +0000 (09:30 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 9 Apr 2026 19:19:32 +0000 (20:19 +0100)
The driver reuses the OF node of the parent multi-function device but
fails to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: bcc61f1c44fd ("regulator: max77650: add regulator support")
Cc: stable@vger.kernel.org # 5.1
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260408073055.5183-4-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/max77650-regulator.c

index a809264c77fc8e6764e81152852ba59ec1fec03d..11b04a13f889a2cf9c527f0d3cb7373012716bb5 100644 (file)
@@ -337,7 +337,7 @@ static int max77650_regulator_probe(struct platform_device *pdev)
        parent = dev->parent;
 
        if (!dev->of_node)
-               dev->of_node = parent->of_node;
+               device_set_of_node_from_dev(dev, parent);
 
        rdescs = devm_kcalloc(dev, MAX77650_REGULATOR_NUM_REGULATORS,
                              sizeof(*rdescs), GFP_KERNEL);