]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: imu: inv_icm42600: change invalid data error to -EBUSY
authorJean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Sun, 24 Aug 2025 16:39:29 +0000 (12:39 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:22:58 +0000 (16:22 +0200)
[ Upstream commit dfdc31e7ccf3ac1d5ec01d5120c71e14745e3dd8 ]

Temperature sensor returns the temperature of the mechanical parts
of the chip. If both accel and gyro are off, the temperature sensor is
also automatically turned off and returns invalid data.

In this case, returning -EBUSY error code is better then -EINVAL and
indicates userspace that it needs to retry reading temperature in
another context.

Fixes: bc3eb0207fb5 ("iio: imu: inv_icm42600: add temperature sensor support")
Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Cc: stable@vger.kernel.org
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Reviewed-by: Sean Nyekjaer <sean@geanix.com>
Link: https://patch.msgid.link/20250808-inv-icm42600-change-temperature-error-code-v1-1-986fbf63b77d@tdk.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
[ Adjust context ]
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/imu/inv_icm42600/inv_icm42600_temp.c

index 91f0f381082bda3dbb95dfe1a38adcdc4eaf5419..8926b48d76614ea70a5e1faf29df837d3a67cab3 100644 (file)
@@ -32,8 +32,12 @@ static int inv_icm42600_temp_read(struct inv_icm42600_state *st, int16_t *temp)
                goto exit;
 
        *temp = (int16_t)be16_to_cpup(raw);
+       /*
+        * Temperature data is invalid if both accel and gyro are off.
+        * Return -EBUSY in this case.
+        */
        if (*temp == INV_ICM42600_DATA_INVALID)
-               ret = -EINVAL;
+               ret = -EBUSY;
 
 exit:
        mutex_unlock(&st->lock);