Use a simpler fix for the byte-reversing warning

diff --git a/src/common/address.c b/src/common/address.c
index 88cbbb74703a6db773abbb7a421cf2472b083582..3e0ea25d909d0c4979d781311f323d399cbf7269 100644 (file)
--- a/src/common/address.c
+++ b/src/common/address.c
@@ -373,10 +373,11 @@ tor_addr_parse_reverse_lookup_name(tor_addr_t *result, const char *address,
       return -1; /* malformed. */
 
     /* reverse the bytes */
-    inaddr.s_addr = (((inaddr.s_addr & (uint32_t)0x000000fful) << 24)
-                     |((inaddr.s_addr & (uint32_t)0x0000ff00ul) << 8)
-                     |((inaddr.s_addr & (uint32_t)0x00ff0000ul) >> 8)
-                     |((inaddr.s_addr & (uint32_t)0xff000000ul) >> 24));
+    inaddr.s_addr = (uint32_t)
+      (((inaddr.s_addr & 0x000000fful) << 24)
+       |((inaddr.s_addr & 0x0000ff00ul) << 8)
+       |((inaddr.s_addr & 0x00ff0000ul) >> 8)
+       |((inaddr.s_addr & 0xff000000ul) >> 24));
 
     if (result) {
       tor_addr_from_in(result, &inaddr);