run: refuse --pty-late for Type=oneshot services

Such combination makes no sense, as by the time the start job
of the oneshot service finishes the main process has already
exited.

Addresses https://github.com/systemd/systemd/pull/36691#discussion_r1988116881

diff --git a/src/run/run.c b/src/run/run.c
index 182925aff0bb8796f1ac5686806b1ec3a398dc46..523993cffdbf5b56624565cc05e907e2efc87b96 100644 (file)
--- a/src/run/run.c
+++ b/src/run/run.c
@@ -775,6 +775,10 @@ static int parse_argv(int argc, char *argv[]) {
                                                "--pty/--pty-late/--pipe is not compatible with --no-block.");
         }
 
+        if (arg_stdio == ARG_STDIO_PTY && arg_pty_late && streq_ptr(arg_service_type, "oneshot"))
+                return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
+                                       "--pty-late is not compatible with --service-type=oneshot.");
+
         if (arg_scope && with_trigger)
                 return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
                                        "Path, socket or timer options are not supported in --scope mode.");