]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
network: drop carrier check for unmanaged interface from link_is_ready_to_configure()
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 28 Jul 2022 07:43:26 +0000 (16:43 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 5 Aug 2022 12:49:27 +0000 (21:49 +0900)
Preparation for later commits. No functional change.

src/network/networkd-link.c
src/network/networkd-route.c

index 7a5bc62415550254d284c687e27402b1fa1b105e..8d4e64769b3a3bae57a4f852faae621d4e80015b 100644 (file)
@@ -98,12 +98,8 @@ bool link_is_ready_to_configure(Link *link, bool allow_unmanaged) {
         if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED, LINK_STATE_UNMANAGED))
                 return false;
 
-        if (!link->network) {
-                if (!allow_unmanaged)
-                        return false;
-
-                return link_has_carrier(link);
-        }
+        if (!link->network)
+                return allow_unmanaged;
 
         if (!link->network->configure_without_carrier) {
                 if (link->set_flags_messages > 0)
index 921b031b2963c3507412e020a5f72a44ca5578ce..71e578d89820f5c40e658c5966b30cb75832b939 100644 (file)
@@ -1298,7 +1298,8 @@ static int route_is_ready_to_configure(const Route *route, Link *link) {
                 if (r < 0)
                         return false;
                 if (r > 0) {
-                        if (!link_is_ready_to_configure(l, true))
+                        if (!link_is_ready_to_configure(l, /* allow_unmanaged = */ true) ||
+                            !link_has_carrier(l))
                                 return false;
 
                         m->ifindex = l->ifindex;