cpupower: remove extern declarations in cmd functions

extern char *optarg and extern int optind, opterr, optopt are
already declared by <getopt.h>, which is included at the top of
the file. Repeating extern declarations inside a function body
is misleading and unnecessary.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

diff --git a/tools/power/cpupower/utils/cpufreq-info.c b/tools/power/cpupower/utils/cpufreq-info.c
index 5fe01e516817e8b8a3dfd6eb6d3a095c909dffea..5a242b491a9d04f1615ba46e2f1a21eec53784c8 100644 (file)
--- a/tools/power/cpupower/utils/cpufreq-info.c
+++ b/tools/power/cpupower/utils/cpufreq-info.c
@@ -542,8 +542,6 @@ static struct option info_opts[] = {
 
 int cmd_freq_info(int argc, char **argv)
 {
-       extern char *optarg;
-       extern int optind, opterr, optopt;
        int ret = 0, cont = 1;
        unsigned int cpu = 0;
        unsigned int human = 0;

diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c
index c5e60a39cfa619ebf517aa4d51f8e9a6d5d27ce1..06cd4b2801325e41ed49a68783df7d901d6df03a 100644 (file)
--- a/tools/power/cpupower/utils/cpufreq-set.c
+++ b/tools/power/cpupower/utils/cpufreq-set.c
@@ -195,8 +195,6 @@ static int do_one_cpu(unsigned int cpu, struct cpufreq_policy *new_pol,
 
 int cmd_freq_set(int argc, char **argv)
 {
-       extern char *optarg;
-       extern int optind, opterr, optopt;
        int ret = 0, cont = 1;
        int double_parm = 0, related = 0, policychange = 0;
        unsigned long freq = 0;

diff --git a/tools/power/cpupower/utils/cpuidle-info.c b/tools/power/cpupower/utils/cpuidle-info.c
index 81b4763a97d6de87a367f31a3e55f9a059bb916e..ccb37125bd37efa39f6c9bc4d3e04787b65d26e5 100644 (file)
--- a/tools/power/cpupower/utils/cpuidle-info.c
+++ b/tools/power/cpupower/utils/cpuidle-info.c
@@ -139,8 +139,6 @@ static inline void cpuidle_exit(int fail)
 
 int cmd_idle_info(int argc, char **argv)
 {
-       extern char *optarg;
-       extern int optind, opterr, optopt;
        int ret = 0, cont = 1, output_param = 0, verbose = 1;
        unsigned int cpu = 0;
 

diff --git a/tools/power/cpupower/utils/cpuidle-set.c b/tools/power/cpupower/utils/cpuidle-set.c
index a551d1d4ac51307355a45dfeea106791eb61c111..703094f1343cee9fa889629618a498b75b18b3a1 100644 (file)
--- a/tools/power/cpupower/utils/cpuidle-set.c
+++ b/tools/power/cpupower/utils/cpuidle-set.c
@@ -24,8 +24,6 @@ static struct option info_opts[] = {
 
 int cmd_idle_set(int argc, char **argv)
 {
-       extern char *optarg;
-       extern int optind, opterr, optopt;
        int ret = 0, cont = 1, param = 0, disabled;
        unsigned long long latency = 0, state_latency;
        unsigned int cpu = 0, idlestate = 0, idlestates = 0;

diff --git a/tools/power/cpupower/utils/cpupower-info.c b/tools/power/cpupower/utils/cpupower-info.c
index 18fd7751f509fd2247a4eb78fecf7d6dae5975f0..79154d71e4982a5353a10f8f9b31635d3e88d63b 100644 (file)
--- a/tools/power/cpupower/utils/cpupower-info.c
+++ b/tools/power/cpupower/utils/cpupower-info.c
@@ -28,8 +28,6 @@ static void print_wrong_arg_exit(void)
 
 int cmd_info(int argc, char **argv)
 {
-       extern char *optarg;
-       extern int optind, opterr, optopt;
        unsigned int cpu;
        struct utsname uts;
 

diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
index 550a942e72ce7d833bda04b94b88a913eb1f47e3..c2176b9fa57d4452d3d4e0b5206a30c616c42346 100644 (file)
--- a/tools/power/cpupower/utils/cpupower-set.c
+++ b/tools/power/cpupower/utils/cpupower-set.c
@@ -33,8 +33,6 @@ static void print_wrong_arg_exit(void)
 
 int cmd_set(int argc, char **argv)
 {
-       extern char *optarg;
-       extern int optind, opterr, optopt;
        unsigned int cpu;
        struct utsname uts;