]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
home: mark various bus messages we write user records to as sensitive
authorLennart Poettering <lennart@poettering.net>
Wed, 29 Apr 2020 14:24:41 +0000 (16:24 +0200)
committerLennart Poettering <lennart@poettering.net>
Wed, 29 Apr 2020 14:32:46 +0000 (16:32 +0200)
let's make sure that when we append potentially sensitive data to a bus
message we set the sensitive flag on the message object.

src/home/home-util.c
src/home/homectl.c

index 69ab645484d8377ed0629015d73fc5249c6f9c32..51406fd234567a7421eaae33f4fb9dcd2653f67e 100644 (file)
@@ -124,6 +124,8 @@ int bus_message_append_secret(sd_bus_message *m, UserRecord *secret) {
         if (r < 0)
                 return r;
 
+        (void) sd_bus_message_sensitive(m);
+
         return sd_bus_message_append(m, "s", formatted);
 }
 
index 9b614325a50b9eeebd1693047bdf6bdbf57674fd..c98bf8b5408f6d3571b7749144408f670f8f14f2 100644 (file)
@@ -1435,6 +1435,8 @@ static int create_home(int argc, char *argv[], void *userdata) {
                 if (r < 0)
                         return bus_log_create_error(r);
 
+                (void) sd_bus_message_sensitive(m);
+
                 r = sd_bus_message_append(m, "s", formatted);
                 if (r < 0)
                         return bus_log_create_error(r);
@@ -1637,6 +1639,8 @@ static int update_home(int argc, char *argv[], void *userdata) {
                 if (r < 0)
                         return r;
 
+                (void) sd_bus_message_sensitive(m);
+
                 r = sd_bus_message_append(m, "s", formatted);
                 if (r < 0)
                         return bus_log_create_error(r);