- don't do inline string interpolation when logging

diff --git a/doc/build/faq.rst b/doc/build/faq.rst
index 12d8e0acc6605408c952c6ce29491a63fb03b548..586f667545f3fe1f824dedad1fc8d95fa3feb6e9 100644 (file)
--- a/doc/build/faq.rst
+++ b/doc/build/faq.rst
@@ -757,14 +757,14 @@ using a recipe like the following::
     def before_cursor_execute(conn, cursor, statement,
                             parameters, context, executemany):
         conn.info.setdefault('query_start_time', []).append(time.time())
-        logger.debug("Start Query: %s" % statement)
+        logger.debug("Start Query: %s", statement)
 
     @event.listens_for(Engine, "after_cursor_execute")
     def after_cursor_execute(conn, cursor, statement,
                             parameters, context, executemany):
         total = time.time() - conn.info['query_start_time'].pop(-1)
         logger.debug("Query Complete!")
-        logger.debug("Total Time: %f" % total)
+        logger.debug("Total Time: %f", total)
 
 Above, we use the :meth:`.ConnectionEvents.before_cursor_execute` and
 :meth:`.ConnectionEvents.after_cursor_execute` events to establish an interception

diff --git a/lib/sqlalchemy/dialects/mysql/base.py b/lib/sqlalchemy/dialects/mysql/base.py
index 2fb054d0c20fbecb892a84e19292302d016b0de3..58eb3afa03cfdf88e825d7a823e964e509182191 100644 (file)
--- a/lib/sqlalchemy/dialects/mysql/base.py
+++ b/lib/sqlalchemy/dialects/mysql/base.py
@@ -2593,7 +2593,7 @@ class MySQLDialect(default.DefaultDialect):
                 pass
             else:
                 self.logger.info(
-                    "Converting unknown KEY type %s to a plain KEY" % flavor)
+                    "Converting unknown KEY type %s to a plain KEY", flavor)
                 pass
             index_d = {}
             index_d['name'] = spec['name']

diff --git a/lib/sqlalchemy/orm/strategies.py b/lib/sqlalchemy/orm/strategies.py
index cdb501c14f6ec1f8944d6a7413411d89586575fe..d95f17f648e3df9ceb744911a314e59f89fc12e7 100644 (file)
--- a/lib/sqlalchemy/orm/strategies.py
+++ b/lib/sqlalchemy/orm/strategies.py
@@ -373,7 +373,7 @@ class LazyLoader(AbstractRelationshipLoader):
                         self._equated_columns[c] = self._equated_columns[col]
 
             self.logger.info("%s will use query.get() to "
-                             "optimize instance loads" % self)
+                             "optimize instance loads", self)
 
     def init_class_attribute(self, mapper):
         self.is_class_level = True