Author: Kieran Whitbread <k.j.whitbread@qmul.ac.uk>

Bug 2858: Segment violation in HTCP

diff --git a/src/htcp.cc b/src/htcp.cc
index 96a42281b35abb15add6274c454d72dee708c51f..7bf02e2501b50ff0e45e7e8f2c8fad02ef203174 100644 (file)
--- a/src/htcp.cc
+++ b/src/htcp.cc
@@ -1270,6 +1270,13 @@ htcpHandleClr(htcpDataHeader * hdr, char *buf, int sz, IpAddress &from)
         return;
     }
 
+    if (!s->request) {
+        debugs(31, 2, "htcpHandleTstRequest: failed to parse request");
+        htcpLogHtcp(from, dhdr->opcode, LOG_UDP_INVALID, dash_str);
+        htcpFreeSpecifier(s);
+        return;
+    }
+
     if (!htcpAccessCheck(Config.accessList.htcp_clr, s, from)) {
         debugs(31, 2, "htcpHandleClr: Access denied");
         htcpLogHtcp(from, hdr->opcode, LOG_UDP_DENIED, s->uri);