accel/ivpu: Improve BO alloc/free warnings

Add additional warnings related to allocation and
deallocation of buffer objects to better track possible
memory leaks and generally the BO's lifecycle.

Introduce checks for handle_count to ensure it is zero
before creating a new handle, and exactly one
after successfully creating a handle.

Introduce also a check to warn if the VMA node is not
empty when freeing the buffer object.

Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
Link: https://lore.kernel.org/r/20250925145154.1446427-1-maciej.falkowski@linux.intel.com

diff --git a/drivers/accel/ivpu/ivpu_gem.c b/drivers/accel/ivpu/ivpu_gem.c
index 38ecf933d144dd896446f6c1c378c2c78ad7c166..e9830ad48d4b024a4066c974f3c8ba720605831f 100644 (file)
--- a/drivers/accel/ivpu/ivpu_gem.c
+++ b/drivers/accel/ivpu/ivpu_gem.c
@@ -332,6 +332,7 @@ static void ivpu_gem_bo_free(struct drm_gem_object *obj)
        drm_WARN_ON(&vdev->drm, bo->ctx);
 
        drm_WARN_ON(obj->dev, refcount_read(&bo->base.pages_use_count) > 1);
+       drm_WARN_ON(obj->dev, bo->base.base.vma_node.vm_files.rb_node);
        drm_gem_shmem_free(&bo->base);
 }
 
@@ -370,12 +371,16 @@ int ivpu_bo_create_ioctl(struct drm_device *dev, void *data, struct drm_file *fi
                return PTR_ERR(bo);
        }
 
+       drm_WARN_ON(&vdev->drm, bo->base.base.handle_count != 0);
+
        ret = drm_gem_handle_create(file, &bo->base.base, &args->handle);
-       if (ret)
+       if (ret) {
                ivpu_err(vdev, "Failed to create handle for BO: %pe (ctx %u size %llu flags 0x%x)",
                         bo, file_priv->ctx.id, args->size, args->flags);
-       else
+       } else {
                args->vpu_addr = bo->vpu_addr;
+               drm_WARN_ON(&vdev->drm, bo->base.base.handle_count != 1);
+       }
 
        drm_gem_object_put(&bo->base.base);