fuse: do not allow mapping a non-regular backing file

commit e9c8da670e749f7dedc53e3af54a87b041918092 upstream.

We do not support passthrough operations other than read/write on
regular file, so allowing non-regular backing files makes no sense.

Fixes: efad7153bf93 ("fuse: allow O_PATH fd for FUSE_DEV_IOC_BACKING_OPEN")
Cc: stable@vger.kernel.org
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: Bernd Schubert <bschubert@ddn.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c
index bbac547dfcb3c8b976206814b5da4b1dfa847891..6bfd09dda9e3e6888e1da9d6c5a64d109030a911 100644 (file)
--- a/fs/fuse/passthrough.c
+++ b/fs/fuse/passthrough.c
@@ -233,6 +233,11 @@ int fuse_backing_open(struct fuse_conn *fc, struct fuse_backing_map *map)
        if (!file)
                goto out;
 
+       /* read/write/splice/mmap passthrough only relevant for regular files */
+       res = d_is_dir(file->f_path.dentry) ? -EISDIR : -EINVAL;
+       if (!d_is_reg(file->f_path.dentry))
+               goto out_fput;
+
        backing_sb = file_inode(file)->i_sb;
        res = -ELOOP;
        if (backing_sb->s_stack_depth >= fc->max_stack_depth)