]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Add missing check for hostname answer_len in dnsserv size
authorNick Mathewson <nickm@torproject.org>
Sat, 15 Jan 2011 18:09:12 +0000 (13:09 -0500)
committerNick Mathewson <nickm@torproject.org>
Sat, 15 Jan 2011 18:09:12 +0000 (13:09 -0500)
This is checked elsewhere too, but let's be RFC-conformant.

src/or/dnsserv.c

index 57c449311fd6c1ba7a7077ad0f9a82b53043d3c9..f8b5c3cdd2e1460f7f6ffeb50e4454de32ca421e 100644 (file)
@@ -271,6 +271,7 @@ dnsserv_resolved(edge_connection_t *conn,
                                      name,
                                      1, (char*)answer, ttl);
   } else if (answer_type == RESOLVED_TYPE_HOSTNAME &&
+             answer_len < 256 &&
              conn->socks_request->command == SOCKS_COMMAND_RESOLVE_PTR) {
     char *ans = tor_strndup(answer, answer_len);
     evdns_server_request_add_ptr_reply(req, NULL,