ASoC: fsl_easrc: Fix event generation in fsl_easrc_iec958_set_reg()

ALSA controls should return 1 if the value in the control changed but the
control put operation fsl_easrc_set_reg() only returns 0 or a negative
error code, causing ALSA to not generate any change events. Add a suitable
check by using regmap_update_bits_check() with the underlying regmap, this
is more clearly and simply correct than trying to verify that one of the
generic ops is exactly equivalent to this one.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://patch.msgid.link/20260205-asoc-fsl-easrc-fix-events-v1-2-39d4c766918b@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_easrc.c
index 5b6204923e8ab9cf6dd7fbc93e8b6773e80bc015..6c56134c60cc810ef5ead528dafcf1550f0a349b 100644 (file)
--- a/sound/soc/fsl/fsl_easrc.c
+++ b/sound/soc/fsl/fsl_easrc.c
@@ -96,14 +96,17 @@ static int fsl_easrc_set_reg(struct snd_kcontrol *kcontrol,
        struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
        struct soc_mreg_control *mc =
                (struct soc_mreg_control *)kcontrol->private_value;
+       struct fsl_asrc *easrc = snd_soc_component_get_drvdata(component);
        unsigned int regval = ucontrol->value.integer.value[0];
+       bool changed;
        int ret;
 
-       ret = snd_soc_component_write(component, mc->regbase, regval);
-       if (ret < 0)
+       ret = regmap_update_bits_check(easrc->regmap, mc->regbase,
+                                      GENMASK(31, 0), regval, &changed);
+       if (ret != 0)
                return ret;
 
-       return 0;
+       return changed;
 }
 
 #define SOC_SINGLE_REG_RW(xname, xreg) \