Coverity 1038089: error check fseek call

diff --git a/src/util-error.c b/src/util-error.c
index 2cb7d38f7d12c4012e0e80f7b912b69d17ccb437..2ffb0df8857e0cb2b71460b9fbd5e136fcbcdcb3 100644 (file)
--- a/src/util-error.c
+++ b/src/util-error.c
@@ -278,6 +278,7 @@ const char * SCErrorToString(SCError err)
         CASE_CODE (SC_ERR_THREAD_QUEUE);
         CASE_CODE (SC_WARN_XFF_INVALID_MODE);
         CASE_CODE (SC_WARN_XFF_INVALID_HEADER);
+        CASE_CODE (SC_ERR_THRESHOLD_SETUP);
     }
 
     return "UNKNOWN_ERROR";

diff --git a/src/util-error.h b/src/util-error.h
index c7494990fe63db136f5e64f5165f3a1bc53dbad9..d9d58c0816bce5c769dee82e0bcafa4e65a112bf 100644 (file)
--- a/src/util-error.h
+++ b/src/util-error.h
@@ -267,6 +267,7 @@ typedef enum {
     SC_ERR_THREAD_QUEUE,
     SC_WARN_XFF_INVALID_MODE,
     SC_WARN_XFF_INVALID_HEADER,
+    SC_ERR_THRESHOLD_SETUP,
 } SCError;
 
 const char *SCErrorToString(SCError);

diff --git a/src/util-threshold-config.c b/src/util-threshold-config.c
index fa7cc10a34d35d4f04ebbf73a3821edf2ddf3acc..e064509056071f49303c3845a8521a2995d2f710 100644 (file)
--- a/src/util-threshold-config.c
+++ b/src/util-threshold-config.c
@@ -920,7 +920,11 @@ int SCThresholdConfLineLength(FILE *fd) {
     if (pos < 0)
         pos = 0;
 
-    fseek(fd, pos, SEEK_SET);
+    if (fseek(fd, pos, SEEK_SET) < 0) {
+        SCLogError(SC_ERR_THRESHOLD_SETUP, "threshold fseek failure: %s",
+                strerror(errno));
+        return -1;
+    }
     return len;
 }