]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
dns-rr: tighten rules on parsing RR keys from JSON
authorLennart Poettering <lennart@amutable.com>
Thu, 26 Feb 2026 14:51:09 +0000 (15:51 +0100)
committerLennart Poettering <lennart@amutable.com>
Tue, 24 Mar 2026 20:24:47 +0000 (21:24 +0100)
let's ensure the name is actually a valid DNS name.

src/shared/dns-rr.c

index 0fa730c13baa289fed14821b66f81ffc01ea4749..58d26e3609b1b3f78b2eebe87528d8e4bb5e1328 100644 (file)
@@ -2215,6 +2215,12 @@ int dns_resource_key_from_json(sd_json_variant *v, DnsResourceKey **ret) {
         if (r < 0)
                 return r;
 
+        r = dns_name_is_valid(p.name);
+        if (r < 0)
+                return r;
+        if (r == 0)
+                return -EBADMSG;
+
         key = dns_resource_key_new(p.class, p.type, p.name);
         if (!key)
                 return -ENOMEM;