pyglue: check talloc buffer for random bytes

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/python/pyglue.c b/python/pyglue.c
index 0e1bf82fa7a39d55b2164ab142f1f2d3ca9b2acd..5ee2b68b8ad26e34ea5d584c2ff9625fbcca0a24 100644 (file)
--- a/python/pyglue.c
+++ b/python/pyglue.c
@@ -101,6 +101,10 @@ static PyObject *py_generate_random_bytes(PyObject *self, PyObject *args)
                return NULL;
 
        bytes = talloc_zero_size(NULL, len);
+       if (bytes == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
        generate_random_buffer(bytes, len);
        ret = PyBytes_FromStringAndSize((const char *)bytes, len);
        talloc_free(bytes);

diff --git a/selftest/knownfail.d/segfault-test_random-bytes b/selftest/knownfail.d/segfault-test_random-bytes
deleted file mode 100644 (file)
index d818819..0000000
--- a/selftest/knownfail.d/segfault-test_random-bytes
+++ /dev/null
@@ -1 +0,0 @@
-^samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_random_bytes