Retire VMCIQueuePair_AllocPriv

Nothing uses VMCIQueuePair_Alloc anymore, since we got rid of
the non-privilege public version (VMCIQPair_Alloc always takes
privilege flags). This change deletes the old version of
VMCIQueuePair_Alloc and renames VMCIQueuePair_AllocPriv to
VMCIQueuePair_Alloc.

Signed-off-by: Marcelo Vanzin <mvanzin@vmware.com>

diff --git a/open-vm-tools/modules/linux/vmci/vmciQPair.c b/open-vm-tools/modules/linux/vmci/vmciQPair.c
index c29289a12c5bae40cf3ffe3978b11c40ab3fc055..329bed6276d40b336cfe3aaa3f5f2431b863e091 100644 (file)
--- a/open-vm-tools/modules/linux/vmci/vmciQPair.c
+++ b/open-vm-tools/modules/linux/vmci/vmciQPair.c
@@ -147,14 +147,14 @@ VMCIQPair_Alloc(VMCIQPair **qpair,            // OUT
    myQPair->flags = flags;
    myQPair->privFlags = privFlags;
 
-   retval = VMCIQueuePair_AllocPriv(handle,
-                                    &myQPair->produceQ,
-                                    myQPair->produceQSize,
-                                    &myQPair->consumeQ,
-                                    myQPair->consumeQSize,
-                                    myQPair->peer,
-                                    myQPair->flags,
-                                    myQPair->privFlags);
+   retval = VMCIQueuePair_Alloc(handle,
+                                &myQPair->produceQ,
+                                myQPair->produceQSize,
+                                &myQPair->consumeQ,
+                                myQPair->consumeQSize,
+                                myQPair->peer,
+                                myQPair->flags,
+                                myQPair->privFlags);
 
    if (retval < VMCI_SUCCESS) {
       VMCI_FreeKernelMem(myQPair, sizeof *myQPair);

diff --git a/open-vm-tools/modules/linux/vmci/vmciQueuePair.c b/open-vm-tools/modules/linux/vmci/vmciQueuePair.c
index 1a15b5a6070efd7d7d3e46fb4c7b58e4fb6638f1..91cbd332575f5a12f8d56ce8e36c8f292cf996a6 100644 (file)
--- a/open-vm-tools/modules/linux/vmci/vmciQueuePair.c
+++ b/open-vm-tools/modules/linux/vmci/vmciQueuePair.c
@@ -424,44 +424,16 @@ QueuePairList_GetHead(void)
  *
  * VMCIQueuePair_Alloc --
  *
- *      Allocates a VMCI QueuePair. Only checks validity of input arguments.
- *      Real work is done in the OS-specific helper routine.
- *
- * Results:
- *      Success or failure.
- *
- * Side effects:
- *      Memory is allocated.
- *
- *-----------------------------------------------------------------------------
- */
-
-int
-VMCIQueuePair_Alloc(VMCIHandle *handle,     // IN/OUT:
-                    VMCIQueue  **produceQ,  // OUT:
-                    uint64     produceSize, // IN:
-                    VMCIQueue  **consumeQ,  // OUT:
-                    uint64     consumeSize, // IN:
-                    VMCIId     peer,        // IN:
-                    uint32     flags)       // IN:
-{
-   ASSERT_ON_COMPILE(sizeof(VMCIQueueHeader) <= PAGE_SIZE);
-
-   return VMCIQueuePair_AllocPriv(handle, produceQ, produceSize, consumeQ, consumeSize, peer, flags, VMCI_NO_PRIVILEGE_FLAGS);
-}
-
-
-/*
- *-----------------------------------------------------------------------------
- *
- * VMCIQueuePair_AllocPriv --
- *
- *      Provided for compatibility with the host API. Always returns an error
- *      since requesting privileges from the guest is not allowed. Use
- *      VMCIQueuePair_Alloc instead.
+ *      Allocates a VMCI QueuePair. Only checks validity of input
+ *      arguments.  Real work is done in the OS-specific helper
+ *      routine. The privilege flags argument is present to provide
+ *      compatibility with the host API; anything other than
+ *      VMCI_NO_PRIVILEGE_FLAGS will result in the error
+ *      VMCI_ERROR_NO_ACCESS, since requesting privileges from the
+ *      guest is not allowed.
  *
  * Results:
- *      An error.
+ *      VMCI_SUCCESS on success, appropriate error code otherwise.
  *
  * Side effects:
  *      None.
@@ -470,14 +442,14 @@ VMCIQueuePair_Alloc(VMCIHandle *handle,     // IN/OUT:
  */
 
 int
-VMCIQueuePair_AllocPriv(VMCIHandle *handle,           // IN/OUT:
-                        VMCIQueue  **produceQ,        // OUT:
-                        uint64     produceSize,       // IN:
-                        VMCIQueue  **consumeQ,        // OUT:
-                        uint64     consumeSize,       // IN:
-                        VMCIId     peer,              // IN:
-                        uint32     flags,             // IN:
-                        VMCIPrivilegeFlags privFlags) // IN:
+VMCIQueuePair_Alloc(VMCIHandle *handle,           // IN/OUT:
+                    VMCIQueue  **produceQ,        // OUT:
+                    uint64     produceSize,       // IN:
+                    VMCIQueue  **consumeQ,        // OUT:
+                    uint64     consumeSize,       // IN:
+                    VMCIId     peer,              // IN:
+                    uint32     flags,             // IN:
+                    VMCIPrivilegeFlags privFlags) // IN:
 {
    if (privFlags != VMCI_NO_PRIVILEGE_FLAGS) {
       return VMCI_ERROR_NO_ACCESS;

diff --git a/open-vm-tools/modules/linux/vmci/vmciQueuePairInt.h b/open-vm-tools/modules/linux/vmci/vmciQueuePairInt.h
index 24db38d02f5d79e776cd43a2d346718cbc5125dc..7b013f4cf80689139a6a1a9fad352cc9440b0052 100644 (file)
--- a/open-vm-tools/modules/linux/vmci/vmciQueuePairInt.h
+++ b/open-vm-tools/modules/linux/vmci/vmciQueuePairInt.h
@@ -33,11 +33,8 @@ void VMCIQueuePair_Exit(void);
 void VMCIQueuePair_Sync(void);
 int VMCIQueuePair_Alloc(VMCIHandle *handle, VMCIQueue **produceQ,
                         uint64 produceSize, VMCIQueue **consumeQ,
-                        uint64 consumeSize, VMCIId peer, uint32 flags);
-int VMCIQueuePair_AllocPriv(VMCIHandle *handle, VMCIQueue **produceQ,
-                            uint64 produceSize, VMCIQueue **consumeQ,
-                            uint64 consumeSize, VMCIId peer, uint32 flags,
-                            VMCIPrivilegeFlags privFlags);
+                        uint64 consumeSize, VMCIId peer, uint32 flags,
+                        VMCIPrivilegeFlags privFlags);
 int VMCIQueuePair_Detach(VMCIHandle handle);
 
 void VMCIQueuePair_Convert(Bool toLocal, Bool deviceReset);