]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: dac: ad5421: use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Mon, 1 Sep 2025 13:57:26 +0000 (21:57 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 1 Sep 2025 19:43:43 +0000 (20:43 +0100)
Change the 'ret' variable in ad5421_update_ctrl() from unsigned int to
int, as it needs to store either negative error codes or zero returned
by ad5421_write_unlocked().

Fixes: 5691b23489db ("staging:iio:dac: Add AD5421 driver")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Link: https://patch.msgid.link/20250901135726.17601-3-rongqianfeng@vivo.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad5421.c

index 1462ee640b16863e779bb550fa64445b5c8bd72c..d9d7031c443250b57aba89b89b1a3a9524483264 100644 (file)
@@ -186,7 +186,7 @@ static int ad5421_update_ctrl(struct iio_dev *indio_dev, unsigned int set,
        unsigned int clr)
 {
        struct ad5421_state *st = iio_priv(indio_dev);
-       unsigned int ret;
+       int ret;
 
        mutex_lock(&st->lock);