]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: mpt3sas: Set ioc->manu_pg11.EEDPTagMode directly to 1
authorPaul Menzel <pmenzel@molgen.mpg.de>
Thu, 12 Dec 2024 22:18:12 +0000 (23:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:46:55 +0000 (12:46 +0100)
[ Upstream commit ad7c3c0cb8f61d6d5a48b83e62ca4a9fd2f26153 ]

Currently, the code does:

    if (x == 0) {
     x &= ~0x3;
x |= 0x1;
    }

Zeroing bits 0 and 1 of a variable that is 0 is not necessary. So directly
set the variable to 1.

Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Fixes: f92363d12359 ("[SCSI] mpt3sas: add new driver supporting 12GB SAS")
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Link: https://lore.kernel.org/r/20241212221817.78940-2-pmenzel@molgen.mpg.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/mpt3sas/mpt3sas_base.c

index 768635de93da9a53261677a371b4a6aaf0c04187..78b178aa46e948b1c1371a08e782fa2bdfd6b063 100644 (file)
@@ -4771,8 +4771,7 @@ _base_static_config_pages(struct MPT3SAS_ADAPTER *ioc)
        if (!ioc->is_gen35_ioc && ioc->manu_pg11.EEDPTagMode == 0) {
                pr_err("%s: overriding NVDATA EEDPTagMode setting\n",
                    ioc->name);
-               ioc->manu_pg11.EEDPTagMode &= ~0x3;
-               ioc->manu_pg11.EEDPTagMode |= 0x1;
+               ioc->manu_pg11.EEDPTagMode = 0x1;
                mpt3sas_config_set_manufacturing_pg11(ioc, &mpi_reply,
                    &ioc->manu_pg11);
        }