]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: usb-audio: Avoid multiple assignments in mixer_quirks
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Mon, 26 May 2025 14:07:45 +0000 (17:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Oct 2025 11:44:05 +0000 (13:44 +0200)
[ Upstream commit 03ddd3bdb94df3edb1f2408b57cfb00b3d92a208 ]

Handle report from checkpatch.pl:

  CHECK: multiple assignments should be avoided

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250526-dualsense-alsa-jack-v1-6-1a821463b632@collabora.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/usb/mixer_quirks.c

index 78c0feb7dcdb778d4f0adb8cda333d8eb1054349..1eae6e83d02597725eb2a25f6673e8831d35ec4b 100644 (file)
@@ -1737,7 +1737,8 @@ static int snd_microii_spdif_default_put(struct snd_kcontrol *kcontrol,
        unsigned int pval, pval_old;
        int err;
 
-       pval = pval_old = kcontrol->private_value;
+       pval = kcontrol->private_value;
+       pval_old = pval;
        pval &= 0xfffff0f0;
        pval |= (ucontrol->value.iec958.status[1] & 0x0f) << 8;
        pval |= (ucontrol->value.iec958.status[0] & 0x0f);