[master] Added comment about unused-parameter warning disabling for clang.

Adding such comments was discussed and agreed on jabber with Jinmei.

diff --git a/src/bin/dhcp4/Makefile.am b/src/bin/dhcp4/Makefile.am
index 8c804d64b5f645e4c69d8bdb9dda43bde985daac..704642f51ecae962a8ec81143408e2868207e85b 100644 (file)
--- a/src/bin/dhcp4/Makefile.am
+++ b/src/bin/dhcp4/Makefile.am
@@ -33,6 +33,8 @@ pkglibexec_PROGRAMS = b10-dhcp4
 b10_dhcp4_SOURCES = main.cc dhcp4_srv.cc dhcp4_srv.h
 
 if USE_CLANGPP
+# Disable unused parameter warning caused by some of the
+# Boost headers when compiling with clang.
 b10_dhcp4_CXXFLAGS = -Wno-unused-parameter
 endif
 

diff --git a/src/bin/dhcp4/tests/Makefile.am b/src/bin/dhcp4/tests/Makefile.am
index 187e01b844fec92b796eca9926b7d8b7a5ef2d82..07de39362a5e0aae17687a3b3fd2d41fd6de5fea 100644 (file)
--- a/src/bin/dhcp4/tests/Makefile.am
+++ b/src/bin/dhcp4/tests/Makefile.am
@@ -48,6 +48,8 @@ dhcp4_unittests_SOURCES += dhcp4_unittests.cc
 dhcp4_unittests_SOURCES += dhcp4_srv_unittest.cc
 
 if USE_CLANGPP
+# Disable unused parameter warning caused by some of the
+# Boost headers when compiling with clang.
 dhcp4_unittests_CXXFLAGS = -Wno-unused-parameter
 endif
 

diff --git a/src/bin/dhcp6/Makefile.am b/src/bin/dhcp6/Makefile.am
index 7da82070de53457dff261a0e33e8492c59ddca13..16b17eddf802f5c8c50ba9f46ad885a0b3f97a2f 100644 (file)
--- a/src/bin/dhcp6/Makefile.am
+++ b/src/bin/dhcp6/Makefile.am
@@ -35,6 +35,8 @@ pkglibexec_PROGRAMS = b10-dhcp6
 b10_dhcp6_SOURCES = main.cc dhcp6_srv.cc dhcp6_srv.h
 
 if USE_CLANGPP
+# Disable unused parameter warning caused by some of the
+# Boost headers when compiling with clang.
 b10_dhcp6_CXXFLAGS = -Wno-unused-parameter
 endif
 

diff --git a/src/bin/dhcp6/tests/Makefile.am b/src/bin/dhcp6/tests/Makefile.am
index ee98049f7ec887d53f34d801b5e146dd0da47d7c..c1a8f3c3c84ffd07856101bc7f0ca170f1234570 100644 (file)
--- a/src/bin/dhcp6/tests/Makefile.am
+++ b/src/bin/dhcp6/tests/Makefile.am
@@ -44,6 +44,8 @@ dhcp6_unittests_SOURCES += dhcp6_unittests.cc
 dhcp6_unittests_SOURCES += dhcp6_srv_unittest.cc
 
 if USE_CLANGPP
+# Disable unused parameter warning caused by some of the
+# Boost headers when compiling with clang.
 dhcp6_unittests_CXXFLAGS = -Wno-unused-parameter
 endif
 

diff --git a/src/lib/dhcp/Makefile.am b/src/lib/dhcp/Makefile.am
index 05b863e2765a5776eadf1c426eac81806cb1d052..dc1545baba058fe65ffac51cf5b806c7411587f6 100644 (file)
--- a/src/lib/dhcp/Makefile.am
+++ b/src/lib/dhcp/Makefile.am
@@ -39,5 +39,7 @@ libdhcp___la_LIBADD  += $(top_builddir)/src/lib/util/libutil.la
 libdhcp___la_LDFLAGS  = -no-undefined -version-info 1:0:0
 
 if USE_CLANGPP
+# Disable unused parameter warning caused by some of the
+# Boost headers when compiling with clang.
 libdhcp___la_CXXFLAGS += -Wno-unused-parameter
 endif

diff --git a/src/lib/dhcp/tests/Makefile.am b/src/lib/dhcp/tests/Makefile.am
index 20f712535f56cf4436ef2f7e89fd4547992f74ee..4c86ee725392dc5aa48213e81a584b6f4af16ef2 100644 (file)
--- a/src/lib/dhcp/tests/Makefile.am
+++ b/src/lib/dhcp/tests/Makefile.am
@@ -44,7 +44,8 @@ libdhcp___unittests_CXXFLAGS = $(AM_CXXFLAGS)
 
 if USE_CLANGPP
 # This is to workaround unused variables tcout and tcerr in
-# log4cplus's streams.h and unused parameters from boost::posix_time.
+# log4cplus's streams.h and unused parameters from some of the
+# Boost headers.
 libdhcp___unittests_CXXFLAGS += -Wno-unused-variable -Wno-unused-parameter
 endif
 libdhcp___unittests_LDADD  = $(GTEST_LDADD)

diff --git a/tests/tools/perfdhcp/Makefile.am b/tests/tools/perfdhcp/Makefile.am
index 6b3ea248bd2f632ce1060cf5492f43f14ea3167c..6ebc00f92afd7c1a048493d2d2b853e69cfeea58 100644 (file)
--- a/tests/tools/perfdhcp/Makefile.am
+++ b/tests/tools/perfdhcp/Makefile.am
@@ -27,6 +27,8 @@ libperfdhcp___la_SOURCES += pkt_transform.cc pkt_transform.h
 
 libperfdhcp___la_CXXFLAGS = $(AM_CXXFLAGS)
 if USE_CLANGPP
+# Disable unused parameter warning caused by some of the
+# Boost headers when compiling with clang.
 libperfdhcp___la_CXXFLAGS += -Wno-unused-parameter
 endif
 

diff --git a/tests/tools/perfdhcp/tests/Makefile.am b/tests/tools/perfdhcp/tests/Makefile.am
index 3147feaf1e1d6e53e91cd525e3ebb1e0f817ec39..d4034b391a301c733e71f2977bf79f16ad9b25da 100644 (file)
--- a/tests/tools/perfdhcp/tests/Makefile.am
+++ b/tests/tools/perfdhcp/tests/Makefile.am
@@ -27,6 +27,8 @@ run_unittests_CPPFLAGS = $(AM_CPPFLAGS) $(GTEST_INCLUDES)
 run_unittests_LDFLAGS  = $(AM_LDFLAGS)  $(GTEST_LDFLAGS)
 
 if USE_CLANGPP
+# Disable unused parameter warning caused by some of the
+# Boost headers when compiling with clang.
 run_unittests_CXXFLAGS = -Wno-unused-parameter
 endif