]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: rtw89: don't check done-ack for entering PS
authorChin-Yen Lee <timlee@realtek.com>
Thu, 24 Oct 2024 05:55:09 +0000 (13:55 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Fri, 1 Nov 2024 02:08:25 +0000 (10:08 +0800)
In WoWLAN mode, driver will disable interrupt after calling H2C command
for entering PS mode, but it may lead to failing to enter deep PS mode by
firmware because the done-ack of the H2C from firmware is not handled by
driver. In fact, the done-ack for entering PS is not necessary for driver
to check, so remove it.

Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241024055509.8000-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/fw.c

index 1fc1ee46b3a39d9f55b040b251c017b4bb6c2f7c..6df275b92e921ddb57a050a66d68863be57d406a 100644 (file)
@@ -2508,7 +2508,7 @@ int rtw89_fw_h2c_lps_parm(struct rtw89_dev *rtwdev,
        rtw89_h2c_pkt_set_hdr(rtwdev, skb, FWCMD_TYPE_H2C,
                              H2C_CAT_MAC,
                              H2C_CL_MAC_PS,
-                             H2C_FUNC_MAC_LPS_PARM, 0, 1,
+                             H2C_FUNC_MAC_LPS_PARM, 0, !lps_param->psmode,
                              H2C_LPS_PARM_LEN);
 
        ret = rtw89_h2c_tx(rtwdev, skb, false);