]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-38815: Accept TLSv3 default in min max test (GH-NNNN) (GH-17437)
authortorsava <torsava@redhat.com>
Mon, 2 Dec 2019 16:15:42 +0000 (17:15 +0100)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 2 Dec 2019 16:15:42 +0000 (08:15 -0800)
Make ssl tests less strict and also accept TLSv3 as the default maximum
version. This change unbreaks test_min_max_version on Fedora 32.

https://bugs.python.org/issue38815

Lib/test/test_ssl.py

index 3cd6e927a469e097d49097d435280988fdea3faf..258816d912b36ac7b7b53d9dcf791cf2ccd17f3d 100644 (file)
@@ -1203,12 +1203,18 @@ class ContextTests(unittest.TestCase):
             # RHEL 8 uses TLS 1.2 by default
             ssl.TLSVersion.TLSv1_2
         }
+        maximum_range = {
+            # stock OpenSSL
+            ssl.TLSVersion.MAXIMUM_SUPPORTED,
+            # Fedora 32 uses TLS 1.3 by default
+            ssl.TLSVersion.TLSv1_3
+        }
 
         self.assertIn(
             ctx.minimum_version, minimum_range
         )
-        self.assertEqual(
-            ctx.maximum_version, ssl.TLSVersion.MAXIMUM_SUPPORTED
+        self.assertIn(
+            ctx.maximum_version, maximum_range
         )
 
         ctx.minimum_version = ssl.TLSVersion.TLSv1_1