]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
netfilter: nfnetlink_queue: remove locking in nfqnl_get_sk_secctx
authorFlorian Westphal <fw@strlen.de>
Thu, 26 Feb 2026 10:12:21 +0000 (11:12 +0100)
committerFlorian Westphal <fw@strlen.de>
Wed, 4 Mar 2026 10:45:45 +0000 (11:45 +0100)
We don't need the cb lock here.
Also, if skb was NULL we'd have crashed already.

Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nfnetlink_queue.c

index 27300d3663dad6d635acf60fa137ffb5ac29294c..5379d8ff39c0e37a5aabef2662f53ca2f7227261 100644 (file)
@@ -592,15 +592,8 @@ static int nfqnl_get_sk_secctx(struct sk_buff *skb, struct lsm_context *ctx)
 {
        int seclen = 0;
 #if IS_ENABLED(CONFIG_NETWORK_SECMARK)
-
-       if (!skb || !sk_fullsock(skb->sk))
-               return 0;
-
-       read_lock_bh(&skb->sk->sk_callback_lock);
-
        if (skb->secmark)
                seclen = security_secid_to_secctx(skb->secmark, ctx);
-       read_unlock_bh(&skb->sk->sk_callback_lock);
 #endif
        return seclen;
 }