]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-92886: [clinic.py] raise exception on invalid input instead of assertion (GH-98051)
authorIrit Katriel <1055913+iritkatriel@users.noreply.github.com>
Fri, 7 Oct 2022 21:41:35 +0000 (22:41 +0100)
committerGitHub <noreply@github.com>
Fri, 7 Oct 2022 21:41:35 +0000 (14:41 -0700)
Tests should pass with -O (assertions off).

Automerge-Triggered-By: GH:iritkatriel
Lib/test/test_clinic.py
Tools/clinic/clinic.py

index 4aa9691a4829d19ea6681c0c6c31bec0250761ee..8ab40c694f711df4116ff1bd496ba3b558d27ec7 100644 (file)
@@ -153,7 +153,7 @@ class ClinicGroupPermuterTest(TestCase):
     def test_have_left_options_but_required_is_empty(self):
         def fn():
             clinic.permute_optional_groups(['a'], [], [])
-        self.assertRaises(AssertionError, fn)
+        self.assertRaises(ValueError, fn)
 
 
 class ClinicLinearFormatTest(TestCase):
index 30a676328706f66dcab03eda9f66dd26ae2c908f..a8687e3470a185ff958c089fdc08a0dbddc536bd 100755 (executable)
@@ -495,7 +495,8 @@ def permute_optional_groups(left, required, right):
     result = []
 
     if not required:
-        assert not left
+        if left:
+            raise ValueError("required is empty but left is not")
 
     accumulator = []
     counts = set()