]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Input: sparcspkr - fix refcount leak in bbc_beep_probe
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 16 May 2022 21:55:55 +0000 (14:55 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:59:25 +0000 (16:59 +0200)
[ Upstream commit c8994b30d71d64d5dcc9bc0edbfdf367171aa96f ]

of_find_node_by_path() calls of_find_node_opts_by_path(),
which returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 9c1a5077fdca ("input: Rewrite sparcspkr device probing.")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220516081018.42728-1-linmq006@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/input/misc/sparcspkr.c

index 4a5afc7fe96ead167bdf1ef918e39b6095c7cfd4..f6e1f38267d9439f0335e8b77ba0fe0be33059e1 100644 (file)
@@ -204,6 +204,7 @@ static int bbc_beep_probe(struct platform_device *op)
 
        info = &state->u.bbc;
        info->clock_freq = of_getintprop_default(dp, "clock-frequency", 0);
+       of_node_put(dp);
        if (!info->clock_freq)
                goto out_free;