]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-40297: Fix test_socket.CANTest.testSendFrame (GH-19548)
authorkarl ding <karlding@users.noreply.github.com>
Tue, 4 May 2021 20:37:13 +0000 (13:37 -0700)
committerGitHub <noreply@github.com>
Tue, 4 May 2021 20:37:13 +0000 (15:37 -0500)
The address tuple for CAN_RAW no longer returns the address family
after the introduction of CAN ISO-TP support in a30f6d45ac3. However,
updating test_socket.CANTest.testSendFrame was missed as part of the
change, so the test incorrectly attempts to index past the last tuple
item to retrieve the address family.

This removes the now-redundant check for equality against socket.AF_CAN,
as the tuple will not contain the address family.

Lib/test/test_socket.py

index 3c45278748a94109cde04f40a11a7d5743b31e9c..828d1f3dcc67012fb471fff57c248417bf1ce1f6 100755 (executable)
@@ -224,7 +224,7 @@ class SocketCANTest(unittest.TestCase):
     the following commands:
     # modprobe vcan
     # ip link add dev vcan0 type vcan
-    # ifconfig vcan0 up
+    # ip link set up vcan0
     """
     interface = 'vcan0'
     bufsize = 128
@@ -2085,7 +2085,6 @@ class CANTest(ThreadedCANSocketTest):
         cf, addr = self.s.recvfrom(self.bufsize)
         self.assertEqual(self.cf, cf)
         self.assertEqual(addr[0], self.interface)
-        self.assertEqual(addr[1], socket.AF_CAN)
 
     def _testSendFrame(self):
         self.cf = self.build_can_frame(0x00, b'\x01\x02\x03\x04\x05')