]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: typec: tcpci: support setting orientation via GPIO
authorXu Yang <xu.yang_2@nxp.com>
Thu, 19 Mar 2026 09:48:49 +0000 (17:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Mar 2026 14:49:56 +0000 (16:49 +0200)
If the chip indicates its "Connection Orientation" standard output control
in STANDARD_OUTPUT_CAPABILITIES register, it can do the thing by
programming CONFIG_STANDARD_OUTPUT register. Due to the optional feature,
the chip which not present this capability currently doesn't have a way to
correctly set the data path. This add the support to set orientation via
a simple GPIO.

Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://patch.msgid.link/20260319-support-setting-orientation-use-gpio-v4-2-ab6dfa8610c2@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpci.c

index 8b7e6eb92ca2e5c8d57bfef6379446a188dc01f4..0148b8f50412b05e6514f46f372c08c77101ac0c 100644 (file)
@@ -7,6 +7,7 @@
 
 #include <linux/bitfield.h>
 #include <linux/delay.h>
+#include <linux/gpio/consumer.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/i2c.h>
@@ -42,6 +43,7 @@ struct tcpci {
 
        struct tcpc_dev tcpc;
        struct tcpci_data *data;
+       struct gpio_desc *orientation_gpio;
 };
 
 struct tcpci_chip {
@@ -316,6 +318,10 @@ static int tcpci_set_orientation(struct tcpc_dev *tcpc,
        struct tcpci *tcpci = tcpc_to_tcpci(tcpc);
        unsigned int reg;
 
+       if (tcpci->orientation_gpio)
+               return gpiod_set_value_cansleep(tcpci->orientation_gpio,
+                                               orientation != TYPEC_ORIENTATION_NORMAL);
+
        switch (orientation) {
        case TYPEC_ORIENTATION_NONE:
                /* We can't put a single output into high impedance */
@@ -903,6 +909,7 @@ EXPORT_SYMBOL_GPL(tcpci_unregister_port);
 static int tcpci_probe(struct i2c_client *client)
 {
        struct tcpci_chip *chip;
+       struct gpio_desc *orient_gpio = NULL;
        int err;
        u16 val = 0;
 
@@ -931,12 +938,23 @@ static int tcpci_probe(struct i2c_client *client)
        if (err < 0)
                return err;
 
+       if (err == 0) {
+               orient_gpio = devm_gpiod_get_optional(&client->dev, "orientation",
+                                                     GPIOD_OUT_LOW);
+               if (IS_ERR(orient_gpio))
+                       return dev_err_probe(&client->dev, PTR_ERR(orient_gpio),
+                                       "unable to acquire orientation gpio\n");
+               err = !!orient_gpio;
+       }
+
        chip->data.set_orientation = err;
 
        chip->tcpci = tcpci_register_port(&client->dev, &chip->data);
        if (IS_ERR(chip->tcpci))
                return PTR_ERR(chip->tcpci);
 
+       chip->tcpci->orientation_gpio = orient_gpio;
+
        err = devm_request_threaded_irq(&client->dev, client->irq, NULL,
                                        _tcpci_irq,
                                        IRQF_SHARED | IRQF_ONESHOT,