]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ksmbd: Fix smb2_set_info_file() kernel-doc comment
authorYang Li <yang.lee@linux.alibaba.com>
Mon, 18 Dec 2023 15:32:33 +0000 (00:32 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Dec 2023 09:41:49 +0000 (10:41 +0100)
[ Upstream commit 4bfd9eed15e163969156e976c62db5ef423e5b0f ]

Fix argument list that the kdoc format and script verified in
smb2_set_info_file().

The warnings were found by running scripts/kernel-doc, which is
caused by using 'make W=1'.
fs/ksmbd/smb2pdu.c:5862: warning: Function parameter or member 'req' not
described in 'smb2_set_info_file'
fs/ksmbd/smb2pdu.c:5862: warning: Excess function parameter 'info_class'
description in 'smb2_set_info_file'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 9496e268e3af ("ksmbd: add request buffer validation in smb2_set_info")
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ksmbd/smb2pdu.c

index 3777d1877f673fd2ca58d2eebe1c362ef628d9ed..36c8890e4bd43683df5d2ca7284f7aa32a7f2272 100644 (file)
@@ -5932,7 +5932,7 @@ static int set_file_mode_info(struct ksmbd_file *fp,
  * smb2_set_info_file() - handler for smb2 set info command
  * @work:      smb work containing set info command buffer
  * @fp:                ksmbd_file pointer
- * @info_class:        smb2 set info class
+ * @req:       request buffer pointer
  * @share:     ksmbd_share_config pointer
  *
  * Return:     0 on success, otherwise error