Merged revisions 76780 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r76780 | lars.gustaebel | 2009-12-13 12:32:27 +0100 (Sun, 13 Dec 2009) | 21 lines

  Issue #7357: No longer suppress fatal extraction errors by
  default.

  TarFile's errorlevel argument controls how errors are
  handled that occur during extraction. There are three
  possible levels 0, 1 and 2. If errorlevel is set to 1 or 2
  fatal errors (e.g. a full filesystem) are raised as
  exceptions. If it is set to 0, which is the default value,
  extraction errors are suppressed, and error messages are
  written to the debug log instead. But, if the debug log is
  not activated, which is the default as well, all these
  errors go unnoticed.

  The original intention was to imitate GNU tar which tries
  to extract as many members as possible instead of stopping
  on the first error. It turns out that this is no good
  default behaviour for a tar library. This patch simply
  changes the default value for the errorlevel argument from
  0 to 1, so that fatal extraction errors are raised as
  EnvironmentError exceptions.
........

diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index 55bb4e3f156190dac000c28770d8972f7cfdfd66..7a67e15d97b6814df7ea8596edbc10f5b9952756 100644 (file)
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -1481,7 +1481,7 @@ class TarFile(object):
     ignore_zeros = False        # If true, skips empty or invalid blocks and
                                 # continues processing.
 
-    errorlevel = 0              # If 0, fatal errors only appear in debug
+    errorlevel = 1              # If 0, fatal errors only appear in debug
                                 # messages (if debug >= 0). If > 0, errors
                                 # are passed to the caller as exceptions.
 

diff --git a/Misc/NEWS b/Misc/NEWS
index d3b26a4e0f724a2a875e401994ea7ff8b807d567..dee6df416d93b19df7dfaea237053c9bf84562d3 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -157,6 +157,9 @@ C-API
 Library
 -------
 
+- Issue #7357: tarfile no longer suppresses fatal extraction errors by
+  default.
+
 - Issue #5949: added check for correct lineends in input from IMAP server
   in imaplib.