]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
alx: Fix an error handling path in 'alx_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 11 Jun 2021 06:13:39 +0000 (08:13 +0200)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:49:14 +0000 (08:49 -0400)
[ Upstream commit 33e381448cf7a05d76ac0b47d4a6531ecd0e5c53 ]

If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.

Fixes: ab69bde6b2e9 ("alx: add a simple AR816x/AR817x device driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/atheros/alx/main.c

index 9de0f9f5b11cacc3788c4086214d4a6d60b064ee..59af298f99e06a728353c16ffe7e797202236ff0 100644 (file)
@@ -1653,6 +1653,7 @@ out_free_netdev:
        free_netdev(netdev);
 out_pci_release:
        pci_release_mem_regions(pdev);
+       pci_disable_pcie_error_reporting(pdev);
 out_pci_disable:
        pci_disable_device(pdev);
        return err;