]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
varlink: drop redundant check
authorLennart Poettering <lennart@poettering.net>
Tue, 7 Jan 2025 13:46:00 +0000 (14:46 +0100)
committerLennart Poettering <lennart@poettering.net>
Sat, 18 Jan 2025 22:24:29 +0000 (23:24 +0100)
sd_varlink_dispatch() alredy validates all this, no need to check this
manually.

src/shared/varlink-io.systemd.service.c

index c369ad2646ceebfe3f1450dc4d8fa920fda5158d..27c270b8e961bb0d4251e790b68c8fb861cf5b5b 100644 (file)
@@ -53,11 +53,6 @@ int varlink_method_set_log_level(sd_varlink *link, sd_json_variant *parameters,
         assert(link);
         assert(parameters);
 
-        /* NOTE: The method does have 1 parameter, but we must compare to 2 here, because
-         * sd_json_variant_elements() breaks abstraction and exposes internal structure of JsonObject. */
-        if (sd_json_variant_elements(parameters) != 2)
-                return sd_varlink_error_invalid_parameter(link, parameters);
-
         r = sd_varlink_dispatch(link, parameters, dispatch_table, &level);
         if (r != 0)
                 return r;