]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: adc: ti-ads1119: Replace IRQF_ONESHOT with IRQF_NO_THREAD
authorFelix Gu <ustc.gu@gmail.com>
Mon, 2 Mar 2026 16:00:04 +0000 (00:00 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 2 Mar 2026 19:58:23 +0000 (19:58 +0000)
As there is no threaded handler, replace devm_request_threaded_irq()
with devm_request_irq(), and as the handler calls iio_trigger_poll()
which may not be called from a threaded handler replace IRQF_ONESHOT
with IRQF_NO_THREAD.

Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT
without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag
in IRQ request and gives a warning if there is no threaded handler.

Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ti-ads1119.c

index 4454f28b2b58e349de8e488a2c66e5b93a357d29..7f771c7023b8fc6a426b155a3f2fe15fc998c67e 100644 (file)
@@ -735,10 +735,8 @@ static int ads1119_probe(struct i2c_client *client)
                return dev_err_probe(dev, ret, "Failed to setup IIO buffer\n");
 
        if (client->irq > 0) {
-               ret = devm_request_threaded_irq(dev, client->irq,
-                                               ads1119_irq_handler,
-                                               NULL, IRQF_ONESHOT,
-                                               "ads1119", indio_dev);
+               ret = devm_request_irq(dev, client->irq, ads1119_irq_handler,
+                                      IRQF_NO_THREAD, "ads1119", indio_dev);
                if (ret)
                        return dev_err_probe(dev, ret,
                                             "Failed to allocate irq\n");