]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
coresight: ctcu: fix the spin_bug
authorJie Gan <jie.gan@oss.qualcomm.com>
Thu, 19 Feb 2026 14:46:57 +0000 (22:46 +0800)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Thu, 26 Feb 2026 10:01:16 +0000 (10:01 +0000)
Acquiring an uninitialized raw_spin_lock is invalid and may trigger
unexpected behavior or spin_bug.

Fixes: f78d206f3d73 ("Coresight: Add Coresight TMC Control Unit driver")
Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20260219-fix-spin-lock-issue-v1-1-557f7d513d7e@oss.qualcomm.com
drivers/hwtracing/coresight/coresight-ctcu-core.c

index 6813ae6e929b05cdc4dcbaab9ff6584653ff4f39..9043cad42f01e6d1facb07a1f85623250535ed9c 100644 (file)
@@ -226,6 +226,7 @@ static int ctcu_probe(struct platform_device *pdev)
        desc.dev = dev;
        desc.ops = &ctcu_ops;
        desc.access = CSDEV_ACCESS_IOMEM(base);
+       raw_spin_lock_init(&drvdata->spin_lock);
 
        drvdata->csdev = coresight_register(&desc);
        if (IS_ERR(drvdata->csdev))