]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net/mlx5e: Drop unused channel parameters
authorDragos Tatulea <dtatulea@nvidia.com>
Mon, 23 Feb 2026 20:41:47 +0000 (22:41 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 26 Feb 2026 09:54:23 +0000 (10:54 +0100)
The channel parameters from struct mlx5_qmgmt_data are
built in mlx5e_queue_mem_alloc() but are not used.

mlx5e_open_channel() builds the channel parameters internally and those
parameters will be the ones that are used when opening the queue.

This patch drops the unused parameters.

Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260223204155.1783580-8-tariqt@nvidia.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index 9e406275e243a92425d6c5a25a0e71f5ad864a15..aca88fed2ac71a8581d165502e4fc8a585dbc3a6 100644 (file)
@@ -5555,7 +5555,6 @@ static const struct netdev_stat_ops mlx5e_stat_ops = {
 
 struct mlx5_qmgmt_data {
        struct mlx5e_channel *c;
-       struct mlx5e_channel_param cparam;
 };
 
 static int mlx5e_queue_mem_alloc(struct net_device *dev,
@@ -5566,7 +5565,6 @@ static int mlx5e_queue_mem_alloc(struct net_device *dev,
        struct mlx5e_priv *priv = netdev_priv(dev);
        struct mlx5e_channels *chs = &priv->channels;
        struct mlx5e_params params = chs->params;
-       struct mlx5_core_dev *mdev;
        int err;
 
        mutex_lock(&priv->state_lock);
@@ -5590,11 +5588,6 @@ static int mlx5e_queue_mem_alloc(struct net_device *dev,
                goto unlock;
        }
 
-       mdev = mlx5_sd_ch_ix_get_dev(priv->mdev, queue_index);
-       err = mlx5e_build_channel_param(mdev, &params, &new->cparam);
-       if (err)
-               goto unlock;
-
        err = mlx5e_open_channel(priv, queue_index, &params, NULL, &new->c);
 unlock:
        mutex_unlock(&priv->state_lock);