]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Reduce the race condition by signalling when the server is ready
authorNeal Norwitz <nnorwitz@gmail.com>
Sat, 26 Jan 2008 21:21:59 +0000 (21:21 +0000)
committerNeal Norwitz <nnorwitz@gmail.com>
Sat, 26 Jan 2008 21:21:59 +0000 (21:21 +0000)
and not trying to connect before.

Lib/test/test_telnetlib.py

index 0a3604e5ae1e7dfb5ade24df25f3d399beb01a31..3a53ad9079c0ff9992e662147c6f51ba5a088af6 100644 (file)
@@ -13,6 +13,7 @@ def server(evt):
     serv.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
     serv.bind(("", 9091))
     serv.listen(5)
+    evt.set()
     try:
         conn, addr = serv.accept()
     except socket.timeout:
@@ -26,6 +27,8 @@ class GeneralTests(TestCase):
     def setUp(self):
         self.evt = threading.Event()
         threading.Thread(target=server, args=(self.evt,)).start()
+        self.evt.wait()
+        self.evt.clear()
         time.sleep(.1)
 
     def tearDown(self):