Added a warning debug if cli_samr_lookup_rids is called with more than 1000

rids as this seems to crash LSASS.EXE more often than not.

diff --git a/source/libsmb/cli_samr.c b/source/libsmb/cli_samr.c
index 29f136427db9a4da94a447c20a91d53b4ffda9e1..d8b300d090c48262f5a40bc3e43e72607ba5f9b0 100644 (file)
--- a/source/libsmb/cli_samr.c
+++ b/source/libsmb/cli_samr.c
@@ -792,7 +792,8 @@ uint32 cli_samr_query_dispinfo(struct cli_state *cli, TALLOC_CTX *mem_ctx,
        return result;
 }
 
-/* Lookup rids */
+/* Lookup rids.  Note that NT4 seems to crash if more than ~1000 rids are
+   looked up in one packet. */
 
 uint32 cli_samr_lookup_rids(struct cli_state *cli, TALLOC_CTX *mem_ctx, 
                            POLICY_HND *domain_pol, uint32 flags,
@@ -805,6 +806,11 @@ uint32 cli_samr_lookup_rids(struct cli_state *cli, TALLOC_CTX *mem_ctx,
        SAMR_R_LOOKUP_RIDS r;
        uint32 result = NT_STATUS_UNSUCCESSFUL, i;
 
+        if (num_rids > 1000) {
+                DEBUG(2, ("cli_samr_lookup_rids: warning: NT4 can crash if "
+                          "more than ~1000 rids are looked up at once.\n"));
+        }
+
        ZERO_STRUCT(q);
        ZERO_STRUCT(r);