lib/dbwrap: clang: Fix 'all argument is an uninitialized value'

Fixes:

lib/dbwrap/dbwrap.c:533:4: warning: 2nd function call argument is an uninitialized value <--[clang]
                        dbwrap_lock_order_unlock(db, lockptr);
                        ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/lib/dbwrap/dbwrap.c b/lib/dbwrap/dbwrap.c
index 5e307ee47cd8feecc221b2710234c8cf3853ba30..29815cb07afa0d02ec1bb8467c24d580405463d3 100644 (file)
--- a/lib/dbwrap/dbwrap.c
+++ b/lib/dbwrap/dbwrap.c
@@ -520,7 +520,7 @@ NTSTATUS dbwrap_do_locked(struct db_context *db, TDB_DATA key,
        struct db_record *rec;
 
        if (db->do_locked != NULL) {
-               struct db_context **lockptr;
+               struct db_context **lockptr = NULL;
                NTSTATUS status;
 
                if (db->lock_order != DBWRAP_LOCK_ORDER_NONE) {
@@ -529,7 +529,8 @@ NTSTATUS dbwrap_do_locked(struct db_context *db, TDB_DATA key,
 
                status = db->do_locked(db, key, fn, private_data);
 
-               if (db->lock_order != DBWRAP_LOCK_ORDER_NONE) {
+               if (db->lock_order != DBWRAP_LOCK_ORDER_NONE &&
+                   lockptr != NULL) {
                        dbwrap_lock_order_unlock(db, lockptr);
                }